search

makerdao / dss-interfaces

Abstract developer interfaces to the Dai Stablecoin System core contracts.
GNU Affero General Public License v3.0
33 stars 26 forks source link

SC-4321: creates an IlkRegistryAbstract #27

Closed godsflaw closed 4 years ago

godsflaw commented 4 years ago

Creates an IlkRegistryAbstract for the new IlkRegistry contract: https://github.com/makerdao/ilk-registry/blob/master/src/IlkRegistry.sol

brianmcmichael commented 4 years ago

You can actually shorten this up by removing the kwargs from the interfaces. Check out how it's done in some of the other interfaces, so like

function file(bytes32 ilk, bytes32 what, uint256 data) external; becomes function file(bytes32, bytes32, uint256) external;

It might help keep some of the functions from spanning multiple lines and help keep the resulting flattened files a little cleaner.

godsflaw commented 4 years ago

You can actually shorten this up by removing the kwargs from the interfaces. Check out how it's done in some of the other interfaces, so like

function file(bytes32 ilk, bytes32 what, uint256 data) external; becomes function file(bytes32, bytes32, uint256) external;

It might help keep some of the functions from spanning multiple lines and help keep the resulting flattened files a little cleaner.

Updated by using a regex, so squint at it.