search

makerdao / dss-interfaces

Abstract developer interfaces to the Dai Stablecoin System core contracts.
GNU Affero General Public License v3.0
33 stars 26 forks source link

add WardsAbstract to dss #62

Closed iamchrissmith closed 2 years ago

iamchrissmith commented 2 years ago

Adding a generic Wards Abstract to our DSS interfaces for use in spells

brianmcmichael commented 2 years ago

FWIW, there is already a dss-exec-lib action available for relying and denying.

https://github.com/makerdao/dss-exec-lib/blob/master/src/DssExecLib.sol#L253-L271

iamchrissmith commented 2 years ago

FWIW, there is already a dss-exec-lib action available for relying and denying.

https://github.com/makerdao/dss-exec-lib/blob/master/src/DssExecLib.sol#L253-L271

Yeah I was looking to replace/better integrate this code from spells: https://github.com/makerdao/spells-mainnet/blob/master/src/DssSpell.t.base.sol#L26-L28

Do you think I should use the Authorizable from that? I feel like this is better to have included in our interfaces repo

brianmcmichael commented 2 years ago

Yeah, this is fine here. Your original comment mentioned it was for spells. This will be helpful for tests if we need it.