makerdao / dss-test

GNU Affero General Public License v3.0
11 stars 9 forks source link

Refactor MCD into a DssInstance struct #12

Closed hexonaut closed 2 years ago

hexonaut commented 2 years ago

This will improve compatibility with the new library-style deploys as we no longer have a layer of indirection with the MCD contract instance. DssInstance can directly be passed around and a library is now used to operate on it.

An example of why this is better: https://github.com/makerdao/dss-bridge/pull/2/files#diff-07e8273439a64d3577ede2634bdd66a71952b4955d846f763e092328d37ddcd6R50

Instead of initializing a DssInstance inside dss-test it can be initialized from the actual repository such as xdomain-dss. This consolidates all the logic into these re-usable deploy scripts so integration tests always match the real deploys.