search

makerdao / dss-test

GNU Affero General Public License v3.0
11 stars 9 forks source link

Add basic setup functionality to MCD #6

Closed hexonaut closed 2 years ago

hexonaut commented 2 years ago

Should probably add tests, but I'm using it in dss-bridge.

gbalabasquer commented 2 years ago

This overlaps a bit with what DssDeploy does. It's true that the main value of DssDeploy is for an actual deployment, however we've been using the test base for testing in other repos a lot as well.

This is though more light weighted and actually allows you to deploy whatever you want as vat, vow and the other core modules, so I see it has a different angle. I guess we need some discussion on how we want to start architecting new repos from now on. In general I prefer to have less dependencies and more mocks, so this can be helpful.

gbalabasquer commented 2 years ago

I think we should avoid using DSValue dependency and just copy and paste the functionality here (reduced to the maximum). Otherwise we are attaching ourselves back to a dapphub dependency. We are still doing through dss-interfaces but I guess that will change at some point.

hexonaut commented 2 years ago

Done.

gbalabasquer commented 2 years ago

Thanks reviewing, and actually dss-interfaces doesn't rely on dapphub repos at all, so we should be perfectly fine now.