makerdao / dss

Dai Stablecoin System
GNU Affero General Public License v3.0
746 stars 413 forks source link

Expose liquidation penalty as a public function #134

Closed yaronvel closed 4 years ago

yaronvel commented 4 years ago

I would kindly ask that the cat would expose the tab calculation as a public function. A similar function exists in compound as an API (in their smart contract). A PR was submitted https://github.com/makerdao/dss/pull/133

The motivation is that we are working on an opt-in liquidation system that needs to read the liquidation penalty value from makerdao’s cat. We plan to read the cat address from the end contract, but changes like in this version, where the chop resolution changed from rad to wad will break our system (in the future, it is still not deployed). Hence, a function that for a given art returns the tab, would really help.

gbalabasquer commented 4 years ago

Replied in the PR.