search

makerdao / exchange-callees

Exchange Callee contracts for LIQ2.0 Flash Loans
GNU Affero General Public License v3.0
31 stars 11 forks source link

UniV3 non-LP tokens support #17

Closed julienmartinlevrai closed 3 years ago

julienmartinlevrai commented 3 years ago

For the spécific case of wstETH, it should be converted to stETH before attempting to swap it. I am unsure whether this logic should be in a conditional inside this contract, if it should be in its own contract, or if it should be together with the Curve contract, which handles only this spécific collatéral. Thoughts ? @godsflaw @gbalabasquer @talbaneth

talbaneth commented 3 years ago

@julienmartinlevrai I reviewed it and aside of @brianmcmichael's comments it looks good. Suggest to merge the curve work at this point. Note the comment I made about applying the renamings (like RouterLike) also to the curve work.

julienmartinlevrai commented 3 years ago

@talbaneth thank you for your review. I will not merge the Curve PR here, rather I will merge this and then rebase the Curve PR to master.

julienmartinlevrai commented 3 years ago

@brianmcmichael @talbaneth PR ready for your approvals

julienmartinlevrai commented 3 years ago

@brianmcmichael @godsflaw @talbaneth thank you for your reviews, merging now