search

makerdao / exchange-callees

Exchange Callee contracts for LIQ2.0 Flash Loans
GNU Affero General Public License v3.0
31 stars 11 forks source link

Curve #18

Closed julienmartinlevrai closed 3 years ago

julienmartinlevrai commented 3 years ago

I added a new contract called CurveCallee, designed for exchanging Wrapped Lido staked Eth to Dai. It uses Curve to get Eth, and then exchanges it for Dai on UniSwap V3.

Before Merging merge #17 and then change the base to master

talbaneth commented 3 years ago

(went over the tests as well)

julienmartinlevrai commented 3 years ago

@iamchrissmith @talbaneth the PR is ready for another round of reviews. The only missing part is renaming the files, which I will do at the very end because I am not sure how well GitHub is going to handle the review comments in the renamed files.

iamchrissmith commented 3 years ago

do we need to update the CI to not use the makerfoundation rpc endpoint?

julienmartinlevrai commented 3 years ago

do we need to update the CI to not use the makerfoundation rpc endpoint?

Yes, but I think I don’t have permissions to update the RPC endpoint, as it is stored in a secret: https://docs.github.com/en/actions/security-guides/encrypted-secrets

Perhaps @gbalabasquer can help ?

talbaneth commented 3 years ago

Cool, still need to handle/address these (see comments), then I think the curve part is fine:

-changeing dai and daiJoin to immutables. -identation stuff -getting the UniV3 path as an input.

When you change the contract and name don't forget to change the test file as well :)

talbaneth commented 3 years ago

Approved, please changes the names though.

julienmartinlevrai commented 3 years ago

@iamchrissmith @talbaneth thank you for your reviews, merging