search

makerdao / exchange-callees

Exchange Callee contracts for LIQ2.0 Flash Loans
GNU Affero General Public License v3.0
31 stars 11 forks source link

godsflaw-20211115: improves deploy scripts #19

Closed godsflaw closed 3 years ago

godsflaw commented 3 years ago 
Running 4 tests for src/test/OasisDexCallee.t.sol:CalleeOtcDaiTest
[PASS] test_rounding_error() (gas: 2702244)
[PASS] test_flash_take_profit() (gas: 3014054)
[PASS] test_flash_take_profit_thin_orderbook() (gas: 2771405)
[PASS] test_flash_take_no_profit() (gas: 2691056)

Running 1 tests for src/test/OasisDexCalleeCharter.t.sol:CalleeOtcDaiTest
[PASS] test_flash_take_profit() (gas: 3166624)

Running 21 tests for src/test/Simulation.t.sol:SimulationTests
[PASS] testFrobMax() (gas: 343291)
[PASS] testTakeLpDaiEthProfit() (gas: 8902803)
[PASS] testGetWeth() (gas: 36273)
[PASS] testTakeLinkV2Profit() (gas: 4435263)
[PASS] testGetLpDaiEth() (gas: 302575)
[PASS] testBarkLpDaiEth() (gas: 883498)
[PASS] testBurnLpDaiEth() (gas: 423682)
[PASS] testDrip() (gas: 54324)
[PASS] testTakeLinkV2NoProfit() (gas: 2985304)
[PASS] testGetLpDaiEthPrice() (gas: 5551)
[PASS] testTakeLpDaiEthNoProfit() (gas: 4736609)
[PASS] testGetDai() (gas: 156462)
[PASS] testGetLinkPrice() (gas: 5684)
[PASS] testGetEthPrice() (gas: 5570)
[PASS] testTakeLinkV3NoProfit() (gas: 3068444)
[PASS] testBarkLink() (gas: 722623)
[PASS] testSwapLinkDai() (gas: 319534)
[PASS] testJoinLink() (gas: 240864)
[PASS] testTakeLinkV3Profit() (gas: 4531830)
[PASS] testJoinLpDaiEth() (gas: 380897)
[PASS] testGetLink() (gas: 165913)

Running 5 tests for src/test/UniswapV2Callee.t.sol:UniswapV2CalleeDaiTest
[PASS] test_complex_path() (gas: 2857662)
[PASS] test_rounding_error() (gas: 2857394)
[PASS] test_flash_take_profit() (gas: 3174834)
[PASS] test_flash_take_profit_thin_orderbook() (gas: 2926533)
[PASS] test_flash_take_no_profit() (gas: 2846184)

Running 1 tests for src/test/UniswapV2CalleeCharter.t.sol:UniswapV2CalleeDaiTest
[PASS] test_flash_take_profit() (gas: 3327236)

Running 7 tests for src/test/WstETHCurveUniv3Callee.t.sol:CurveCalleeTest
[PASS] test_profit() (gas: 1187325)
[PASS] test_baseline() (gas: 1190352)
[PASS] test_poolFee() (gas: 1183214)
[PASS] testFail_badPoolFee() (gas: 1014422)
[PASS] testFail_maxPrice() (gas: 697567)
[PASS] test_bigAmt() (gas: 1202605)
[PASS] test_maxPrice() (gas: 1217455)
julienmartinlevrai commented 3 years ago

@godsflaw : UniV3Callee does not exist anymore. During the UniV3 PR review process, @brianmcmichael suggested to rename it to UniswapV3Callee in order to respect convention. Is there still a UniV3Callee somewhere in the code ? If there is, it is my mistake and should be corrected.

godsflaw commented 3 years ago

@godsflaw : UniV3Callee does not exist anymore. During the UniV3 PR review process, @brianmcmichael suggested to rename it to UniswapV3Callee in order to respect convention. Is there still a UniV3Callee somewhere in the code ? If there is, it is my mistake and should be corrected.

I did see the discussion, but yes, perhaps we missed this in the curve PR: https://github.com/makerdao/exchange-callees/blob/master/src/UniV3Callee.sol#L56

julienmartinlevrai commented 3 years ago

@godsflaw : UniV3Callee does not exist anymore. During the UniV3 PR review process, @brianmcmichael suggested to rename it to UniswapV3Callee in order to respect convention. Is there still a UniV3Callee somewhere in the code ? If there is, it is my mistake and should be corrected.

I did see the discussion, but yes, perhaps we missed this in the curve PR: https://github.com/makerdao/exchange-callees/blob/master/src/UniV3Callee.sol#L56

Probably a merge conflict I didn’t noticed. I just diffed the files and they are the same, so I am going to delete the file and update the déploy scripts and push to this branch, hope you don’t mind.

godsflaw commented 3 years ago 
Running 4 tests for src/test/OasisDexCallee.t.sol:CalleeOtcDaiTest
[PASS] test_rounding_error() (gas: 2702244)
[PASS] test_flash_take_profit() (gas: 3014054)
[PASS] test_flash_take_profit_thin_orderbook() (gas: 2771405)
[PASS] test_flash_take_no_profit() (gas: 2691056)

Running 1 tests for src/test/OasisDexCalleeCharter.t.sol:CalleeOtcDaiTest
[PASS] test_flash_take_profit() (gas: 3166624)

Running 21 tests for src/test/Simulation.t.sol:SimulationTests
[PASS] testFrobMax() (gas: 343291)
[PASS] testTakeLpDaiEthProfit() (gas: 8902583)
[PASS] testGetWeth() (gas: 36273)
[PASS] testTakeLinkV2Profit() (gas: 4435445)
[PASS] testGetLpDaiEth() (gas: 302575)
[PASS] testBarkLpDaiEth() (gas: 883278)
[PASS] testBurnLpDaiEth() (gas: 423682)
[PASS] testDrip() (gas: 54506)
[PASS] testTakeLinkV2NoProfit() (gas: 2985486)
[PASS] testGetLpDaiEthPrice() (gas: 5551)
[PASS] testTakeLpDaiEthNoProfit() (gas: 4736389)
[PASS] testGetDai() (gas: 156462)
[PASS] testGetLinkPrice() (gas: 5684)
[PASS] testGetEthPrice() (gas: 5570)
[PASS] testTakeLinkV3NoProfit() (gas: 3068626)
[PASS] testBarkLink() (gas: 722805)
[PASS] testSwapLinkDai() (gas: 319534)
[PASS] testJoinLink() (gas: 240864)
[PASS] testTakeLinkV3Profit() (gas: 4532012)
[PASS] testJoinLpDaiEth() (gas: 380897)
[PASS] testGetLink() (gas: 165913)

Running 5 tests for src/test/UniswapV2Callee.t.sol:UniswapV2CalleeDaiTest
[PASS] test_complex_path() (gas: 2857662)
[PASS] test_rounding_error() (gas: 2857394)
[PASS] test_flash_take_profit() (gas: 3174834)
[PASS] test_flash_take_profit_thin_orderbook() (gas: 2926533)
[PASS] test_flash_take_no_profit() (gas: 2846184)

Running 1 tests for src/test/UniswapV2CalleeCharter.t.sol:UniswapV2CalleeDaiTest
[PASS] test_flash_take_profit() (gas: 3327236)

Running 7 tests for src/test/WstETHCurveUniv3Callee.t.sol:CurveCalleeTest
[PASS] test_profit() (gas: 1187105)
[PASS] test_baseline() (gas: 1190132)
[PASS] test_poolFee() (gas: 1182994)
[PASS] testFail_badPoolFee() (gas: 1014202)
[PASS] testFail_maxPrice() (gas: 697347)
[PASS] test_bigAmt() (gas: 1202385)
[PASS] test_maxPrice() (gas: 1217235)