search

makerdao / ilk-registry

A publicly-modifiable registry of ilks in the Dai Stablecoin System.
GNU Affero General Public License v3.0
22 stars 18 forks source link

Using hevm test harness #5

Open gbalabasquer opened 4 years ago

gbalabasquer commented 4 years ago

I know unit testing is complicated for this case, but I'd still prefer to keep it without any tests and add this hevm mainnet tests in some other place. If we want to include this repo as submodule of another one is quite possible on dapp test this brings some errors (not 100% sure if that is the case), but for example dss-deploy-scripts used to run dapp test in each dependency, on this repo that would break. mkr-authority e.g. has the same issue.

brianmcmichael commented 4 years ago

We should talk about the best way to approach this and where to put those tests. There aren't really any "units" to test here, so only integration testing is going to be useful.

I'd also like to avoid importing a dss dependency here if possible, otherwise we'd probably need to rebuild this with solc 0.5.x.