Closed andy8052 closed 5 years ago
Do we need to upgrade the dss
version for these specs?
As otherwise CI will run every spec again.
I'd suggest we upgrade dss
only if necessary or after we apply all the pending changes.
Didn't even think about that. I can revert that
Actually seems your PR is setting the dss
commit back to 9b5d1ac
which is the one being used in the CI.
Yeah let's not update dss
in this PR (I think current k-dss
is already on latest master of dss
anyway).
Otherwise, LGTM!
Added the specs for the accessors Vow.dump and End.pot.
I ran the specs and both are passing.