search

makerdao / keg

GNU Affero General Public License v3.0
11 stars 6 forks source link

Remove chug #10

Closed hexonaut closed 3 years ago

hexonaut commented 4 years ago

https://github.com/makerdao/keg/blob/8202cbd88657ad2a6194691db9c5c5d8754fc229/src/Keg.sol#L159-L181

chug is a sub-set of sip. I think we can probably remove it to reduce smart contract risk. The counter-argument is less checks so probably less gas.

hexonaut commented 3 years ago

Delegation no longer relevant with https://github.com/makerdao/keg/pull/12