search

makerdao / keg

GNU Affero General Public License v3.0
11 stars 6 forks source link

Delegation fix #6

Closed NiklasKunkel closed 4 years ago

NiklasKunkel commented 4 years ago

Fixed refactored delegation mechanism, fixed edge cases and added a bunch of tests.

gbalabasquer commented 4 years ago

In general I think this function might be part of another contract. So IMO it would be better to have a keg for governance using suck and another keg for the foundation. I tend to prefer keeping contracts the simplest as possible (that is why I would also say to remove chug in favor of having just sip). Once governance start paying, the function pour will be useless. But anyway this is a personal opinion, so I'll take a look to the PR and give some comments.