makerdao / lockstake

GNU Affero General Public License v3.0
27 stars 13 forks source link

(6) Consider changing comment about ES #15

Open oldchili opened 9 months ago

oldchili commented 9 months ago

https://github.com/makerdao/lockstake/blob/bc63780074ecaf8a3c542d547b7bbff9ffce75f1/src/LockstakeClipper.sol#L473 - Since we do a slip instead of a flux end.snip's grab call will fail. So not sure if we can leave the mention of ES here (and there's a question whether we rely the end or not).

sunbreak1211 commented 9 months ago

This is a good question, and the subject is probably much deeper as today we do not have any mechanism to exit the real MKR that will be shared via the End module in the form of vat.gem. Also grabbing the vault is an issue per se as well as the oracle will be the sticky one, you want the real price instead of that one at the moment you need to cage the ilk.

sunbreak1211 commented 8 months ago

Fix for this: https://github.com/makerdao/lockstake/pull/28