search

makerdao / lockstake

GNU Affero General Public License v3.0
19 stars 11 forks source link

(8) Add engine to disallowed callees list (or change comment) #17

Closed oldchili closed 8 months ago

oldchili commented 8 months ago

https://github.com/makerdao/lockstake/blob/dev/src/LockstakeClipper.sol#L400 - can consider adding the engine here (or at least changing the comment as there are more than 2 contracts now).

sunbreak1211 commented 8 months ago

Added here: https://github.com/makerdao/lockstake/commit/e5359c8d51050b5dbf78c257dbfe25685c10861c Checking there are no tests at all for this, so probably we should need to add some for those contracts.

sunbreak1211 commented 8 months ago

Added test: https://github.com/makerdao/lockstake/pull/1/commits/c02ea6d2475e12bb7c4b6f434076f0f74b392fc6