search

makerdao / lockstake

GNU Affero General Public License v3.0
19 stars 11 forks source link

(14) Are we sure we want to drip on wipe? #23

Closed oldchili closed 8 months ago

oldchili commented 8 months ago

Looking at this - https://github.com/makerdao/lockstake/blob/cab89b5a5d737e9f4e399b323884131e37adb2d6/src/LockstakeEngine.sol#L359. I see in proxy actions we don't drip so wondering why we are not doing the same here. I know dripping makes the system collect more fees, can save the neede keeper for doing it and is more correct semantically. But on the other hand it makes it more complex to wipe the entire debt (up to rounding errors), as it's harder to pre-calculate the needed wad without pre-dripping.

sunbreak1211 commented 8 months ago

Yeah there are merits for both options, but for example in the allocator vault we are dripping on wipe as well.