search

makerdao / lockstake

GNU Affero General Public License v3.0
19 stars 11 forks source link

Remove delFarm #31

Closed oldchili closed 7 months ago

oldchili commented 7 months ago

@sunbreak1211 the only downside I can think of with this implementation is that if governance verifies a farm that it is not the owner of, it will not be able to block depositing.

If we think that's a possible scenario we can use an enum as drafted here - https://github.com/makerdao/lockstake/pull/32 (in case we like this approach, this PR still needs to be finalized for review)

oldchili commented 7 months ago

Closed in favor of https://github.com/makerdao/lockstake/pull/33