Open nmushegian opened 7 years ago
Redeemer issues/ideas:
var wad = from.balanceOf(msg.sender);
to
var wad = from.allowance(msg.sender, this);
and only transfer the amount they approved.
On the other hand, all or nothing is simpler (UI wise).
Does it need to be a DSThing? It uses no math, auth or note functions
you're right its not necessary
Redeem function takes all available balance. Maybe people will want to exchange some MKR tokens initially, not all? We could change this line: On the other hand, all or nothing is simpler (UI wise).
that was my reasoning for removing it as well. I don't really care either way
breaking down updates on the way to sai2
499
498
497
496