Do price rounding better in `sai_maker_otc.py`

makerdao / market-maker-keeper

Maker Keeper Framework: Market maker keepers for OasisDEX, EtherDelta, 0x (RadarRelay, ERCdEX), Paradex, DDEX, IDEX, Bibox, Ethfinex, GoPax, HitBTC, TheOcean, OKEX and Gate.io.

GNU Affero General Public License v3.0

481 stars 183 forks source link

Do price rounding better in `sai_maker_otc.py` #2

Open ghost opened 6 years ago

ghost commented 6 years ago

Due to precision issues, the price rounding mechanism currently used in sai_maker_otc.py doesn't guarantee that a price will always be displayed with the required number of decimal places (e.g. in the Oasis frontend). It may be preferable to round the quantities as well (but to a different number of digits) in order to achieve a consistent number of decimal places.

Authored by @livnev, moved from: https://github.com/makerdao/keeper/issues/35.

adamjsawicki commented 4 years ago

@reverendus Can this be closed? Doesn't look like this file exists in either repo.

ghost commented 4 years ago

@Swixx I think this was about this flag https://github.com/makerdao/market-maker-keeper/blob/master/market_maker_keeper/oasis_market_maker_keeper.py#L111 which doesn't seem to be used for anything anymore. So I would say the issue can be closed as it's about a non-existent feature. Having said that it would be nice to remove the flag as well.