Closed brianmcmichael closed 4 years ago
This looks good but I'm wondering if we should also take the ilk contract addresses from the ilk-registry instead of the config file.
@gbalabasquer I'm happy to make that update. Would probably want to do it in a different PR.
mcd-cli
to use ilk-registry for ilk discovery and validationgem name
commandThe ilk registry feature now acquires ilk information off the blockchain. This takes a little more time (a few seconds) than before so the new component writes out the info to a file. When re-checking ilks, which mcd-cli does on basically every call, it updates the file modification time. This gets checked on every call. If the user hasn't performed a command in the past 10 minutes it will then invalidate the file and re-acquire, otherwise it will read out the existing file. An active user would keep updating the file and not experience the timeout. 10 minutes is arbitrary, an attempt to compromise between not aggressively re-checking but also making it so that if a new collateral type is entered the user can walk away for a bit and re-set the ilk list. Open to suggestions on this mechanic.
Here's the new output on mainnet: