search

makerdao / mips

Maker Improvement Proposals (MIPs)
MIT License
75 stars 123 forks source link

TECH-2595 - Improve / fix the IPFS deployment workflow #1039

Closed sanbotto closed 9 months ago

sanbotto commented 10 months ago

The current workflow has been failing since it was pushed to the master branch. In order for the MIPs to always be available to the public, I think it's convenient to actually have them deployed to IPFS.

This code has already been tested and it works. The Cloudflare account being used is the one that belongs to MakerDAO, and the Filebase account belongs to TechOps, but this can always be quickly changed by simply updating the FILEBASE_* secrets.

sanbotto commented 10 months ago

Nice Santi. Do you wanna add a couple of lines to Readme describing that we are using Filebase to deploy to IPFS and Cloudflare for DNS?

Yeah, makes sense. I'll wait for the mips-ipfs subdomain to be approved before I move on with this.

sanbotto commented 9 months ago

I've added some info about the IPFS deployment to the README and modified the workflow to only upload directories that match MIP*.