search

makerdao / mips

Maker Improvement Proposals (MIPs)
MIT License
75 stars 123 forks source link

The `IFlashMintReceiver` callback should use a more generic function name. #132

Closed alcueca closed 3 years ago

alcueca commented 3 years ago

execute is very generic and could clash with functionality on the receiver or on other callback interfaces.

I would recommend using onFlashMint, since the interface will likely be reused by other projects outside MakerDAO.

hexonaut commented 3 years ago

Thanks for opening these, but it's in the wrong repository.

I've opened a PR to implement this change: https://github.com/hexonaut/dss-flash/pull/8