Allow calls to fail and return the block hash.

makerdao / multicall

Multicall: Aggregate multiple constant function call results into one

MIT License

851 stars 451 forks source link

Closed BlinkyStitt closed 3 years ago

BlinkyStitt commented 4 years ago

Sometimes I'm aggregating calls and I expect some failures. This lets me aggregate them.

Returning the block hash helps me in the event of a re-org.

BlinkyStitt commented 4 years ago

Mainnet: 0xeCCE0ba5d8E2C8Fa9c045722ff0B9b11d5111B30 Ropsten: 0x573414DdCF9FF6D60d4001DAB1A7D682Cec4e4BE

rotcivegaf commented 4 years ago

I like this upgrade, but I dont like the lint and i think you dont respect the previos architecture I make this PR

BlinkyStitt commented 4 years ago

What do you mean by "respect the previous architecture?" I didn't want to reuse the function name since it works differently.

moodysalem commented 4 years ago

can you branch the file into Multicall2.sol instead of changing Multicall? I like/need this change

ethanbennett commented 3 years ago

I believe this was covered by #21