makerdao / protego

GNU Affero General Public License v3.0
10 stars 3 forks source link

Missing script to fetch existing plans from pause #3

Open 0x3phemeralsoul opened 5 months ago

0x3phemeralsoul commented 5 months ago

As decided here: https://github.com/makerdao/protego/pull/2#discussion_r1602112529

amusingaxl commented 4 months ago

I believe we need to refine this a little bit better. We can always fetch the emitted logs, however it is a bit more cumbersome, since DsPause uses LibNote instead of plain events. However, what should this script return exactly?

amusingaxl commented 4 months ago

cc @SidestreamColdMelon

SidestreamColdMelon commented 4 months ago

The proposal was to add a set of js functions + tests + a basic CLI wrapper to this repo to:

Why is this needed: deploying a drop spell is not a trivial operation, therefore the js script itself should also be audited.

If the end goal is the UI, in the future, the UI can simply import audited functions and call them – effectively reusing core functionality and ensuring security-crucial logic.