makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

109 stars 46 forks source link

SC-9633: March 1st, 2021 Urgent Exec #146

Closed hexonaut closed 3 years ago

hexonaut commented 3 years ago

Description

https://app.clubhouse.io/scdomaincommunityteam/story/9633/march-1st-urgent-executive

Contribution Checklist

[x] PR title ends with (SC-<TICKET_NUMBER>)
[x] Link to clubhouse ticket
[x] Code approved
[x] Tests approved
[x] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier
[x] Verify expiration (4 days + 2 hours monthly and 30 days for the rest)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[x] squash and merge this PR

brianmcmichael commented 3 years ago

So far it looks ok. Just waiting on that copy link and hash.

gbalabasquer commented 3 years ago

LGTM, I'll approve as soon as it is archived.

brianmcmichael commented 3 years ago

Looks good. Waiting for archive to approve.