makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

120 stars 48 forks source link

SC-10406 2021-03-26 Executive #152

Closed gbalabasquer closed 3 years ago

gbalabasquer commented 3 years ago

Description

Contribution Checklist

[x] PR title ends with (SC-<TICKET_NUMBER>)
[x] Link to clubhouse ticket
[x] Code approved
[x] Tests approved
[x] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier
[x] Verify expiration (4 days + 2 hours monthly and 30 days for the rest)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

gbalabasquer commented 3 years ago

Spell actions are done, it is just missing the hash as the content seems not to be ready yet.

gbalabasquer commented 3 years ago

@hexonaut @brianmcmichael now it should be fully ready to be reviewed

gbalabasquer commented 3 years ago

Spell archived, ready for final approval.