makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

120 stars 48 forks source link

SC-10761: 2021-04-09 MakerDAO Executive Spell #155

Closed godsflaw closed 3 years ago

godsflaw commented 3 years ago

Description

Adds New Silver to MCD

Contribution Checklist

[x] PR title ends with (SC-<TICKET_NUMBER>)
[x] Link to clubhouse ticket
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier
[x] Verify expiration (4 days monthly and 30 days for the rest)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

gbalabasquer commented 3 years ago

@godsflaw can you please approve this to get it merged?