SC-11421 2021-04-23 Executive

[gbalabasquer]

Description

Contribution Checklist

• [x] PR title ends with (SC-<TICKET_NUMBER>)
• [x] Link to clubhouse ticket
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

LIQ-2.0 Checklist

clipper foreach ilk

• [x] Validate constructor argument(s) are correct
• [x] Ensure that the deployer was removed
• [x] Ensure that the pause proxy was relied
• [x] dog.file(ilk, "clip", clipper)
• [x] clipper.file("vow", vow)
• [x] clipper.file("calc", calc)
• [x] vat.rely(clipper)
• [x] dog.rely(clipper)
• [x] clipper.rely(dog)
• [x] clipper.rely(end)
• [x] clipper.rely(clipperMom)
• [x] clipper.rely(esm)
• [x] flipper.deny(cat) (replaced by the clipper)
• [x] flipper.deny(flipperMom) (to avoid reenabling the flipper without governance delay)
• [x] osm.kiss(clipper)
• [x] osm.kiss(clipperMom)
• [x] dog.file(ilk, "hole", "")
• [x] dog.file(ilk, "chop", "")
• [x] clipper.file("buf", "")
• [x] clipper.file("tail", "")
• [x] clipper.file("cusp", "")
• [x] clipper.file("chip", "")
• [x] clipper.file("tip", "")
• [x] Ensure that the deployer was removed from the calc
• [x] Ensure that the pause proxy was relied on the calc
• [x] calc.file("step", "")
• [x] calc.file("cut", "")
• [x] clipperMom.setPriceTolerance(clipper, ???)
• [x] clipper.upchost()
• [x] Replace flipper to clipper in the ilk-registry
• [x] Add clipper and calc in the chainlog
• [x] Remove flipper from the chainlog

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [ ] squash and merge this PR

[e18r]

tests with the deployed spell

dapp-test: rpc block: latest
Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7803)
[PASS] test_auth_in_sources() (gas: 281473903657199)
[PASS] test_use_eta() (gas: 323577)
[PASS] testOfficeHoursMatches() (gas: 5620)
[PASS] testOnTime() (gas: 3212511)
[PASS] testSpellIsCast_YFI_A_Clip() (gas: 4079995)
[PASS] test_nextCastTime() (gas: 485329)
[PASS] testFailTooEarly() (gas: 372313)
[PASS] testLerp() (gas: 3352390)
[PASS] testClipperMomTripBreaker() (gas: 3300658)
[PASS] test_auth() (gas: 281473905913199)
[PASS] testSpellIsCast_GENERAL() (gas: 14093202)
[PASS] testSpellIsCast_YFI_A_End() (gas: 4971225)
[PASS] testFailWrongDay() (gas: 372361)
[PASS] testCastCost() (gas: 3218158)
[PASS] testChainlogValues() (gas: 3249130)
[PASS] testClipperMomSetBreaker() (gas: 3428179)
[PASS] testFailTooLate() (gas: 372651)
[PASS] testFailClipperMomTripBreaker() (gas: 3242558)

[gbalabasquer]

Just archived the spell. Can I get two final formal approvals?

[gbalabasquer]

@hexonaut @e18r can someone of you give a final approval please?