makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

120 stars 48 forks source link

PE-544 2021-05-24 Monthly Executive Spell #163

Closed gbalabasquer closed 3 years ago

gbalabasquer commented 3 years ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Link to clubhouse ticket
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier
[ ] Verify expiration (4 days monthly and 30 days for the rest)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

gbalabasquer commented 3 years ago

@naszam @julienmartinlevrai not sure if tests are passing yet, but you should be able to start reviewing the spell. If some of you have a local node it would be nice to see if you can provide faster results.

gbalabasquer commented 3 years ago

@julienmartinlevrai @naszam please let me know if I should proceed deploying the spell as soon as the tests pass in the CI

julienmartinlevrai commented 3 years ago

Checked:

[x] hash of vote
[x] contents of vote
[x] SES address
[x] SES amount
[x] hashes of MIPs
[x] contents of MIPs
[x] variable names of MIPs
[x] payment action
[x] payment test

Tests are passing.

LGTM

julienmartinlevrai commented 3 years ago

Tests with deployed spell are passing, also vérified source code on Etherscan. LGTM