makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

108 stars 45 forks source link

PE-617: 2021-07-17 replacement spell #172

Closed kmbarry1 closed 3 years ago

kmbarry1 commented 3 years ago

Description

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Link to clubhouse ticket
[x] Code approved
[x] Tests approved
[x] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier
[x] Verify expiration (4 days monthly and 30 days for the rest)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[x] squash and merge this PR

brianmcmichael commented 3 years ago

This is looking good to me. We probably want @godsflaw and @lucasvo to sign off on this.

brianmcmichael commented 3 years ago

Inspected the RWA inclusion spell and oracle for any other elements we may have missed here.
Tests are passing.
Card added to add more tests.
Retro to be scheduled.

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7737)
[PASS] test_auth_in_sources() (gas: 281473903796024)
[PASS] test_use_eta() (gas: 323351)
[PASS] testOnTime() (gas: 462933)
[PASS] test_nextCastTime() (gas: 325371)
[PASS] testFailTooEarly() (gas: 10357)
[PASS] test_bytecode_matches() (gas: 935689)
[PASS] test_auth() (gas: 281473907231238)
[PASS] testSpellIsCast_GENERAL() (gas: 7494438)
[PASS] testFailWrongDay() (gas: 10489)
[PASS] testCastCost() (gas: 468525)
[PASS] test_RWA002_values() (gas: 482936)
[PASS] testFailTooLate() (gas: 10643)

kmbarry1 commented 3 years ago

Btw Lucas reviewed and told me it looked good to him.

kmbarry1 commented 3 years ago

I'm trying to get the extra test Tal suggested to work (confirming that a draw is possible). Fighting with rounding error at the moment but once that works I'll deploy.

brianmcmichael commented 3 years ago

Tests passing at d0ec4b68fdb83fa0af23c638a0e5446f8e27ad92

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12237)
[PASS] test_auth_in_sources() (gas: 281473903958410)
[PASS] test_use_eta() (gas: 325251)
[PASS] testOnTime() (gas: 453033)
[PASS] test_nextCastTime() (gas: 326071)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 933589)
[PASS] test_auth() (gas: 281473906414558)
[PASS] testSpellIsCast_GENERAL() (gas: 6650923)
[PASS] testFailWrongDay() (gas: 8589)
[PASS] testCastCost() (gas: 454625)
[PASS] test_RWA002_values() (gas: 616662)
[PASS] testFailTooLate() (gas: 8743)

godsflaw commented 3 years ago

Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12237)
[PASS] test_auth_in_sources() (gas: 281473903958410)
[PASS] test_use_eta() (gas: 325251)
[PASS] testOnTime() (gas: 453033)
[PASS] test_nextCastTime() (gas: 326071)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 933589)
[PASS] test_auth() (gas: 281473906414558)
[PASS] testSpellIsCast_GENERAL() (gas: 6650923)
[PASS] testFailWrongDay() (gas: 8589)
[PASS] testCastCost() (gas: 454625)
[PASS] test_RWA002_values() (gas: 616662)
[PASS] testFailTooLate() (gas: 8743)

kmbarry1 commented 3 years ago

Archived. Ready for final approvals before merge (can wait until Monday).