2021-07-26 RWA003 - RWA006 Spell

[hieronx]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Link to clubhouse ticket
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [x] squash and merge this PR

Centrifuge Asset Checklist

A few notes about scope.

In scope:

• The URN
• The RWA token
• The Manager
• The Join Adapter (AuthGemJoin)
• The Liquidation Manager (usually reused)

Out of scope (unless you really want to):

• Anything beyond the manager (centrifuge/tinlake code)

checklist

RWA003

• [x] validate CentrifugeCollateralValues
  • [x] validate addresses
    • [x] validate MCD_JOIN (join adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against MCD_JOIN_RWA002_A link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] vat address matches changelog
        • [x] ilk is the bytes32 representation of "RWANNN-A"
          • can use seth --to-bytes32 $(seth --from-ascii "RWANNN") to get correct value for comparison
        • [x] gem matches the GEM value from the Centrifuge config
      • [x] validate wards
        • [x] deployer has been denied
        • [x] the URN address from this config has been relied
        • [x] the MCD pause proxy has been relied
        • [x] no other addresses have been relied (check internal transactions)
    • [x] validate GEM (dummy token used as collateral in adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against RWA002 link TODO(after this batch, we should probably compare to RWA003 since they changed the code a bit)
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] name is in RWA-NNN format
        • [x] symbol is in RWANNN format
        • [x] totalSupply is 1000000000000000000 (10^18)
      • [x] ensure a transfer transaction moved the totalSupply over to the manager (OPERATOR address below)
    • [x] validate OPERATOR (aka "manager" and same as both conduits)
      • [x] Make sure the contract is verified
        • [x] diff the new code against RWA002_A_INPUT_CONDUIT link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct by checking the values of the public fields that store them
        • [x] dai address matches changelog (MCD_DAI) address
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] end address matches changelog (MCD_END) address
        • [x] gem address matches (DROP) from the test values
        • [x] liq address matches changelog (MIP21_LIQUIDATION_ORACLE) address
        • [x] urn address is zero (if spell is for mainnet) OR matches URN from this config (if spell is for a testnet)
        • [x] vat address matches changelog (MCD_VAT) address
        • [x] vow address matches changelog (MCD_VOW) address
      • [x] validate wards
        • [x] ensure rely() has been called with ROOT from the test values
        • [ ] ensure rely() has been called on the clerk
        • [x] ensure deny() has been called on the contract's deployer address
    • [x] INPUT_CONDUIT is the same address as OPERATOR
    • [x] OUTPUT_CONDUIT is the same address as OPERATOR
    • [x] validate URN
      • [x] make sure contract is verified
        • [x] diff against RWA002_A_URN link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] validate constructor args via public fields
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] gemJoin address matches MCD_JOIN from this config
        • [x] jug address matches changelog (MCD_JUG) address
        • [x] outputConduit address matches OUTPUT_CONDUIT from this config
        • [x] vat address matches changelog (MCD_VAT) address
      • [x] validate wards
        • [x] the pause proxy (MCD_PAUSE_PROXY) has been relied
        • [x] the deployer address has been denied
        • [x] no other wards have been added (check internal txes)
  • [x] validate IDs
    • [x] gemID is formatted as RWANNN
    • [x] joinID is formatted as MCD_JOIN_RWANNN_A
    • [x] urnID is formatted as RWANNN_A_URN
    • [x] inputConduitID is formatted as RWANNN_A_INPUT_CONDUIT
    • [x] outputConduitID is formatted as RWANNN_A_OUTPUT_CONDUIT
    • [x] pipID is formatted as PIP_RWANNN
  • [x] validate other constants
    • [x] ilk is formatted as RWANNN-A
    • [x] ilk_string is formatted as RWANNN-A
    • [x] ilkRegistryName is formatted as RWANNN-A: Centrifuge: <entity>
    • [x] there is a link to a MakerDAO on-chain governance poll where the correct values are defined
    • [x] RATE matches the intended value when converted to a yearly APY and matches the value in the poll
    • [x] CEIL matches the debt ceiling value specified in the poll
    • [x] PRICE is [(CEIL + 2 years of fees) MAT 10^14] (e.g. 2 10^6 1.06^2 * 1.05)
    • [x] MAT corresponds to the collateralization ratio specified in the poll
    • [x] TAU is usually 0, but can be used as a grace period to remediate and cure()
    • [x] DOC is the IPFS hash of the correct DROP token subscription agreement

RWA004

• [x] validate CentrifugeCollateralValues
  • [x] validate addresses
    • [x] validate MCD_JOIN (join adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against MCD_JOIN_RWA002_A link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] vat address matches changelog
        • [x] ilk is the bytes32 representation of "RWANNN-A"
          • can use seth --to-bytes32 $(seth --from-ascii "RWANNN") to get correct value for comparison
        • [x] gem matches the GEM value from the Centrifuge config
      • [x] validate wards
        • [x] deployer has been denied
        • [x] the URN address from this config has been relied
        • [x] the MCD pause proxy has been relied
        • [x] no other addresses have been relied (check internal transactions)
    • [x] validate GEM (dummy token used as collateral in adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against RWA002 link TODO(after this batch, we should probably compare to RWA003 since they changed the code a bit)
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] name is in RWA-NNN format
        • [x] symbol is in RWANNN format
        • [x] totalSupply is 1000000000000000000 (10^18)
      • [x] ensure a transfer transaction moved the totalSupply over to the manager (OPERATOR address below)
    • [x] validate OPERATOR (aka "manager" and same as both conduits)
      • [x] Make sure the contract is verified
        • [x] diff the new code against RWA002_A_INPUT_CONDUIT link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct by checking the values of the public fields that store them
        • [x] dai address matches changelog (MCD_DAI) address
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] end address matches changelog (MCD_END) address
        • [x] gem address matches (DROP) from the test values
        • [x] liq address matches changelog (MIP21_LIQUIDATION_ORACLE) address
        • [x] urn address is zero (if spell is for mainnet) OR matches URN from this config (if spell is for a testnet)
        • [x] vat address matches changelog (MCD_VAT) address
        • [x] vow address matches changelog (MCD_VOW) address
      • [x] validate wards
        • [x] ensure rely() has been called with ROOT from the test values
        • [ ] ensure rely() has been called on the clerk
        • [x] ensure deny() has been called on the contract's deployer address
    • [x] INPUT_CONDUIT is the same address as OPERATOR
    • [x] OUTPUT_CONDUIT is the same address as OPERATOR
    • [x] validate URN
      • [x] make sure contract is verified
        • [x] diff against RWA002_A_URN link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] validate constructor args via public fields
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] gemJoin address matches MCD_JOIN from this config
        • [x] jug address matches changelog (MCD_JUG) address
        • [x] outputConduit address matches OUTPUT_CONDUIT from this config
        • [x] vat address matches changelog (MCD_VAT) address
      • [x] validate wards
        • [x] the pause proxy (MCD_PAUSE_PROXY) has been relied
        • [x] the deployer address has been denied
        • [x] no other wards have been added (check internal txes)
  • [x] validate IDs
    • [x] gemID is formatted as RWANNN
    • [x] joinID is formatted as MCD_JOIN_RWANNN_A
    • [x] urnID is formatted as RWANNN_A_URN
    • [x] inputConduitID is formatted as RWANNN_A_INPUT_CONDUIT
    • [x] outputConduitID is formatted as RWANNN_A_OUTPUT_CONDUIT
    • [x] pipID is formatted as PIP_RWANNN
  • [x] validate other constants
    • [x] ilk is formatted as RWANNN-A
    • [x] ilk_string is formatted as RWANNN-A
    • [x] ilkRegistryName is formatted as RWANNN-A: Centrifuge: <entity>
    • [x] there is a link to a MakerDAO on-chain governance poll where the correct values are defined
    • [x] RATE matches the intended value when converted to a yearly APY and matches the value in the poll
    • [x] CEIL matches the debt ceiling value specified in the poll
    • [x] PRICE is [(CEIL + 2 years of fees) MAT 10^14] (e.g. 2 10^6 1.06^2 * 1.05)
    • [x] MAT corresponds to the collateralization ratio specified in the poll
    • [x] TAU is usually 0, but can be used as a grace period to remediate and cure()
    • [x] DOC is the IPFS hash of the correct DROP token subscription agreement

RWA005

• [x] validate CentrifugeCollateralValues
  • [x] validate addresses
    • [x] validate MCD_JOIN (join adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against MCD_JOIN_RWA002_A link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] vat address matches changelog
        • [x] ilk is the bytes32 representation of "RWANNN-A"
          • can use seth --to-bytes32 $(seth --from-ascii "RWANNN") to get correct value for comparison
        • [x] gem matches the GEM value from the Centrifuge config
      • [x] validate wards
        • [x] deployer has been denied
        • [x] the URN address from this config has been relied
        • [x] the MCD pause proxy has been relied
        • [x] no other addresses have been relied (check internal transactions)
    • [x] validate GEM (dummy token used as collateral in adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against RWA002 link TODO(after this batch, we should probably compare to RWA003 since they changed the code a bit)
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] name is in RWA-NNN format
        • [x] symbol is in RWANNN format
        • [x] totalSupply is 1000000000000000000 (10^18)
      • [x] ensure a transfer transaction moved the totalSupply over to the manager (OPERATOR address below)
    • [x] validate OPERATOR (aka "manager" and same as both conduits)
      • [x] Make sure the contract is verified
        • [x] diff the new code against RWA002_A_INPUT_CONDUIT link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct by checking the values of the public fields that store them
        • [x] dai address matches changelog (MCD_DAI) address
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] end address matches changelog (MCD_END) address
        • [x] gem address matches (DROP) from the test values
        • [x] liq address matches changelog (MIP21_LIQUIDATION_ORACLE) address
        • [x] urn address is zero (if spell is for mainnet) OR matches URN from this config (if spell is for a testnet)
        • [x] vat address matches changelog (MCD_VAT) address
        • [x] vow address matches changelog (MCD_VOW) address
      • [x] validate wards
        • [x] ensure rely() has been called with ROOT from the test values
        • [ ] ensure rely() has been called on the clerk
        • [x] ensure deny() has been called on the contract's deployer address
    • [x] INPUT_CONDUIT is the same address as OPERATOR
    • [x] OUTPUT_CONDUIT is the same address as OPERATOR
    • [x] validate URN
      • [x] make sure contract is verified
        • [x] diff against RWA002_A_URN link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] validate constructor args via public fields
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] gemJoin address matches MCD_JOIN from this config
        • [x] jug address matches changelog (MCD_JUG) address
        • [x] outputConduit address matches OUTPUT_CONDUIT from this config
        • [x] vat address matches changelog (MCD_VAT) address
      • [x] validate wards
        • [x] the pause proxy (MCD_PAUSE_PROXY) has been relied
        • [x] the deployer address has been denied
        • [x] no other wards have been added (check internal txes)
  • [x] validate IDs
    • [x] gemID is formatted as RWANNN
    • [x] joinID is formatted as MCD_JOIN_RWANNN_A
    • [x] urnID is formatted as RWANNN_A_URN
    • [x] inputConduitID is formatted as RWANNN_A_INPUT_CONDUIT
    • [x] outputConduitID is formatted as RWANNN_A_OUTPUT_CONDUIT
    • [x] pipID is formatted as PIP_RWANNN
  • [x] validate other constants
    • [x] ilk is formatted as RWANNN-A
    • [x] ilk_string is formatted as RWANNN-A
    • [x] ilkRegistryName is formatted as RWANNN-A: Centrifuge: <entity>
    • [x] there is a link to a MakerDAO on-chain governance poll where the correct values are defined
    • [x] RATE matches the intended value when converted to a yearly APY and matches the value in the poll
    • [x] CEIL matches the debt ceiling value specified in the poll
    • [x] PRICE is [(CEIL + 2 years of fees) MAT 10^14] (e.g. 2 10^6 1.06^2 * 1.05)
    • [x] MAT corresponds to the collateralization ratio specified in the poll
    • [x] TAU is usually 0, but can be used as a grace period to remediate and cure()
    • [x] DOC is the IPFS hash of the correct DROP token subscription agreement

RWA006

• [x] validate CentrifugeCollateralValues
  • [x] validate addresses
    • [x] validate MCD_JOIN (join adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against MCD_JOIN_RWA002_A link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] vat address matches changelog
        • [x] ilk is the bytes32 representation of "RWANNN-A"
          • can use seth --to-bytes32 $(seth --from-ascii "RWANNN") to get correct value for comparison
        • [x] gem matches the GEM value from the Centrifuge config
      • [x] validate wards
        • [x] deployer has been denied
        • [x] the URN address from this config has been relied
        • [x] the MCD pause proxy has been relied
        • [x] no other addresses have been relied (check internal transactions)
    • [x] validate GEM (dummy token used as collateral in adapter)
      • [x] make sure the contract is verified
        • [x] diff the new code against RWA002 link TODO(after this batch, we should probably compare to RWA003 since they changed the code a bit)
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct
        • [x] name is in RWA-NNN format
        • [x] symbol is in RWANNN format
        • [x] totalSupply is 1000000000000000000 (10^18)
      • [x] ensure a transfer transaction moved the totalSupply over to the manager (OPERATOR address below)
    • [x] validate OPERATOR (aka "manager" and same as both conduits)
      • [x] Make sure the contract is verified
        • [x] diff the new code against RWA002_A_INPUT_CONDUIT link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] make sure all constructor args are correct by checking the values of the public fields that store them
        • [x] dai address matches changelog (MCD_DAI) address
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] end address matches changelog (MCD_END) address
        • [ ] gem address matches (DROP) from the test values
        • [x] liq address matches changelog (MIP21_LIQUIDATION_ORACLE) address
        • [x] urn address is zero (if spell is for mainnet) OR matches URN from this config (if spell is for a testnet)
        • [x] vat address matches changelog (MCD_VAT) address
        • [x] vow address matches changelog (MCD_VOW) address
      • [ ] validate wards
        • [ ] ensure rely() has been called with ROOT from the test values
        • [ ] ensure rely() has been called on the clerk
        • [ ] ensure deny() has been called on the contract's deployer address
    • [x] INPUT_CONDUIT is the same address as OPERATOR
    • [x] OUTPUT_CONDUIT is the same address as OPERATOR
    • [x] validate URN
      • [x] make sure contract is verified
        • [x] diff against RWA002_A_URN link
        • [x] ensure same compiler version was used
        • [x] ensure same optimizer settings were used
      • [x] validate constructor args via public fields
        • [x] daiJoin address matches changelog (MCD_JOIN_DAI) address
        • [x] gemJoin address matches MCD_JOIN from this config
        • [x] jug address matches changelog (MCD_JUG) address
        • [x] outputConduit address matches OUTPUT_CONDUIT from this config
        • [x] vat address matches changelog (MCD_VAT) address
      • [x] validate wards
        • [x] the pause proxy (MCD_PAUSE_PROXY) has been relied
        • [x] the deployer address has been denied
        • [x] no other wards have been added (check internal txes)
  • [x] validate IDs
    • [x] gemID is formatted as RWANNN
    • [x] joinID is formatted as MCD_JOIN_RWANNN_A
    • [x] urnID is formatted as RWANNN_A_URN
    • [x] inputConduitID is formatted as RWANNN_A_INPUT_CONDUIT
    • [x] outputConduitID is formatted as RWANNN_A_OUTPUT_CONDUIT
    • [x] pipID is formatted as PIP_RWANNN
  • [x] validate other constants
    • [x] ilk is formatted as RWANNN-A
    • [x] ilk_string is formatted as RWANNN-A
    • [x] ilkRegistryName is formatted as RWANNN-A: Centrifuge: <entity>
    • [x] there is a link to a MakerDAO on-chain governance poll where the correct values are defined
    • [x] RATE matches the intended value when converted to a yearly APY and matches the value in the poll
    • [x] CEIL matches the debt ceiling value specified in the poll (should be 0)
    • [x] PRICE is [(CEIL + 2 years of fees) MAT 10^14] (e.g. 2 10^6 1.06^2 * 1.05) (currently should be 0)
    • [x] MAT corresponds to the collateralization ratio specified in the poll
    • [x] TAU is usually 0, but can be used as a grace period to remediate and cure()
    • [x] DOC is the IPFS hash of the correct DROP token subscription agreement

spell-wide checklist

• [x] validate the spell logic
  • [x] validate Maker changelog address
  • [x] make sure there are no contract-scoped storage variables
  • [x] spell should have (correct) description and hash
  • [x] spell should use MIP21_LIQUIDATION_ORACLE from changelog
  • [x] spell should sanity check the join adapter
    • [x] vat address matches that from the changelog or exec lib
    • [x] ilk matches that defined in the config
    • [x] gem matches GEM from the config
    • [x] join decimals match GEM decimals
  • [x] spell calls init() on the liqudation oracle
  • [x] spell files the pip from init() in the Spotter
  • [x] spell calls vat.init() on the ilk
  • [x] spell calls jug.init() on the ilk
  • [x] spell auths the new adapter on the vat
  • [x] spell sets the debt ceiling for the ilk.line and the global vat.Line
  • [x] spell sets the stability fee
  • [x] spell sets the collateralization ratio
  • [x] spell pokes MCD_SPOT for ilk
  • [x] the spell hopes the OPERATOR on the URN
  • [x] spell adds the collateral to the ilk registry
  • [x] spell stores the following addresses in the CHANGELOG
    • [x] GEM stored under gemID
    • [x] MCD_JOIN stored under joinID
    • [x] URN stored under urnID
    • [x] INPUT_CONDUIT stored under inputConduitID
    • [x] OUTPUT_CONDUIT stored under outputConduitID
    • [x] pip stored under pipID
  • [x] spell bumps the changelog version

[gbalabasquer]

Please make sure src/DssSpell.t.sol has only the needed changes for this spell. I see several differences that should not exist (formatting, spaces, uint256 => uint, missing functions, missing or extra comments, etc). The diff should only show remotion of specific things of the prev spell and addendums of this specific new spell + the new collaterals in the structure. Whatever remains in this PR will be the base for the next ones so we should make sure the test file doesn't get altered in any case that doesn't correspond.

[hieronx]

Please make sure src/DssSpell.t.sol has only the needed changes for this spell. I see several differences that should not exist (formatting, spaces, uint256 => uint, missing functions, missing or extra comments, etc).

@gbalabasquer these differences you mention are the differences that exist between the spell tests in the maker kovan spells repo and the maker mainnet spells repo. @godsflaw has told us that we should keep the differences between the kovan and mainnet versions as small as possible, which is why we've put it together like this.

[gbalabasquer]

@gbalabasquer these differences you mention are the differences that exist between the spell tests in the maker kovan spells repo and the maker mainnet spells repo. @godsflaw has told us that we should keep the differences between the kovan and mainnet versions as small as possible, which is why we've put it together like this.

I guess he meant the test functions, but having the template changed shouldn't be the case. Each week we use the prev spell files as base for the new one. With this approach, the template is broken. Having minimum changes between spells is also helpful to detect exactly what is new in the system.

[gbalabasquer]

I just pushed a commit which reverts the changes that are not related to this spell.

[kmbarry1]

Not sure where the others are with their reviews, but this pretty much LGTM except that we are waiting on the exec copy to be done so we can add the hash. There's also been some discussion that we might add the changes from last week here since the previous executive is having trouble passing.

[talbaneth]

dapp-test: rpc block: latest Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4759) [PASS] test_auth_in_sources() (gas: 281473904021917) [PASS] test_use_eta() (gas: 171113) [PASS] testOnTime() (gas: 6769842) [PASS] test_nextCastTime() (gas: 171955) [PASS] testFailTooEarly() (gas: 3501) [PASS] test_bytecode_matches() (gas: 2310700) [PASS] test_auth() (gas: 281473906858052) [PASS] testSpellIsCast_GENERAL() (gas: 13766183) [PASS] testManagerWards() (gas: 29565) [PASS] testFailWrongDay() (gas: 3655) [PASS] testCastCost() (gas: 6771456) [PASS] testNewChainlogValues() (gas: 6814928) [PASS] test_RWA_values() (gas: 8433612) [PASS] testNewIlkRegistryValues() (gas: 6849127) [PASS] testFailTooLate() (gas: 3853)

Running 2 tests for src/DssSpellManager.t.sol:DssSpellManagerTest [PASS] testWipeAndExit() (gas: 934898) [PASS] testJoinAndDraw() (gas: 592691)

[godsflaw]

Tests with changes for deployed spell:

Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 9759)
[PASS] test_auth_in_sources() (gas: 281473904021948)
[PASS] test_use_eta() (gas: 322773)
[PASS] testOnTime() (gas: 6921502)
[PASS] test_nextCastTime() (gas: 323615)
[PASS] testFailTooEarly() (gas: 8501)
[PASS] test_bytecode_matches() (gas: 2317700)
[PASS] test_auth() (gas: 281473906858084)
[PASS] testSpellIsCast_GENERAL() (gas: 16222006)
[PASS] testManagerWards() (gas: 29565)
[PASS] testFailWrongDay() (gas: 8655)
[PASS] testCastCost() (gas: 6923116)
[PASS] testNewChainlogValues() (gas: 6966588)
[PASS] test_RWA_values() (gas: 8585272)
[PASS] testNewIlkRegistryValues() (gas: 7000787)
[PASS] testFailTooLate() (gas: 8853)

Running 2 tests for src/DssSpellManager.t.sol:DssSpellManagerTest
[PASS] testWipeAndExit() (gas: 934898)
[PASS] testJoinAndDraw() (gas: 592691)

[hieronx]

Tests pass on deployed spell--will approve on merging of deployed spell commit and archival.

Just archived it @kmbarry1