PE-622 August 6th Executive Spell

[talbaneth]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Link to clubhouse ticket
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [ ] squash and merge this PR

[WilfredTA]

• [x] CU Addresses Match
• [x] CU Payment Amounts Match
• [x] Changelog Address Matches
• [x] ETH-B Rate set to 5%
• [x] LRC-A Max Debt Ceiling set to 1 mil using auto line
• [x] UNIV2ETHUSDT-A Max Debt Ceiling set to 0 with autoline
• [x] UNIV2DAIUSDT-A Max Debt Ceiling set to 0 with autoline
• [x] Above Uni tokens ilks removed from Vat's Ilks
• [x] Vat's global Line decreased accordingly
• [x] UNIV2DAIUSDC-A Set to 250 Million

I want to do a sanity check regarding the synchronization of debt, auto line, and the ilk's line + global Line in the Vat. Especially upon initial adjustment from spell deployment, I want to be sure that the collection of updates are atomic. E.g., does purely adjusting via the autoline ensure that this is rational given current debt and given the ilk-specific & global lines in the Vat?

[talbaneth]

Tests pass on my side:

Running 15 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4662) [PASS] test_auth_in_sources() (gas: 281473904032281) [PASS] test_use_eta() (gas: 315915) [PASS] test_core_unit_budgets() (gas: 1236983) [PASS] testOnTime() (gas: 1203183) [PASS] test_nextCastTime() (gas: 316855) [PASS] testFailTooEarly() (gas: 3662) [PASS] test_bytecode_matches() (gas: 2144181) [PASS] test_auth() (gas: 281473906920886) [PASS] testSpellIsCast_GENERAL() (gas: 8040161) [PASS] testFailWrongDay() (gas: 3640) [PASS] testCastCost() (gas: 1204488) [PASS] testNewChainlogValues() (gas: 1207308) [PASS] testNewIlkRegistryValues() (gas: 1397350) [PASS] testFailTooLate() (gas: 3639)

[kmbarry1]

RWA DC tests here if we want to merge them in: https://github.com/makerdao/spells-mainnet/pull/176

Can always merge them later though if we don't want to hold this spell up.

[talbaneth]

RWA DC tests here if we want to merge them in: #176

Can always merge them later though if we don't want to hold this spell up.

yeah, let's do that later.

[talbaneth]

Tests pass on my side with the deployed spell:

Running 15 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12281) [PASS] test_auth_in_sources() (gas: 281473904117019) [PASS] test_use_eta() (gas: 327795) [PASS] test_core_unit_budgets() (gas: 1297521) [PASS] testOnTime() (gas: 1265105) [PASS] test_nextCastTime() (gas: 328659) [PASS] testFailTooEarly() (gas: 8523) [PASS] test_bytecode_matches() (gas: 1714961) [PASS] test_auth() (gas: 281473906953866) [PASS] testSpellIsCast_GENERAL() (gas: 9407647) [PASS] testFailWrongDay() (gas: 8655) [PASS] testCastCost() (gas: 1266697) [PASS] testNewChainlogValues() (gas: 1269475) [PASS] testNewIlkRegistryValues() (gas: 1549265) [PASS] testFailTooLate() (gas: 8831)

[brianmcmichael]

Tests passing locally here.

dapp-test: rpc block: latest
Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12281)
[PASS] test_auth_in_sources() (gas: 281473904117019)
[PASS] test_use_eta() (gas: 327795)
[PASS] test_core_unit_budgets() (gas: 1297751)
[PASS] testOnTime() (gas: 1265335)
[PASS] test_nextCastTime() (gas: 328659)
[PASS] testFailTooEarly() (gas: 8523)
[PASS] test_bytecode_matches() (gas: 1714961)
[PASS] test_auth() (gas: 281473906953866)
[PASS] testSpellIsCast_GENERAL() (gas: 9407877)
[PASS] testFailWrongDay() (gas: 8655)
[PASS] testCastCost() (gas: 1266927)
[PASS] testNewChainlogValues() (gas: 1269705)
[PASS] testNewIlkRegistryValues() (gas: 1549495)
[PASS] testFailTooLate() (gas: 8831)

[kmbarry1]

Got through the following tests before hitting an RPC error:

[PASS] testFail_notScheduled() (gas: 12281)
[PASS] test_auth_in_sources() (gas: 281473904117019)
[PASS] test_use_eta() (gas: 327795)
[PASS] test_core_unit_budgets() (gas: 1297856)
[PASS] testOnTime() (gas: 1265440)
[PASS] test_nextCastTime() (gas: 328659)
[PASS] testFailTooEarly() (gas: 8523)
[PASS] test_bytecode_matches() (gas: 1714961)
[PASS] test_auth() (gas: 281473906953866)

[talbaneth]

Currently waiting for merge of Kurt's RWA DC tests before getting approvals and archiving. Otherwise those tests will be limboed out of the archive.