search

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
108 stars 45 forks source link

Rwa dc tests #176

Closed kmbarry1 closed 3 years ago

kmbarry1 commented 3 years ago

Addresses https://github.com/makerdao/smart-contracts-team-pm/issues/627 for mainnet. Will backport to spells-kovan.

kmbarry1 commented 3 years ago

After some further thought I broke this out into a separate test--will be easier to debug if this ever fails, and it's not really a pure "are the values correct" but rather "are the values consistent with each other". Also since it modifies the system state in the course of execution, it's easier to reason about on its own and this way it can't interfere with other assertions e.g. in checkCollateralValues.

But if there's a strong preference to move it back where was initially I'm okay with that.