makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

108 stars 45 forks source link

PE-637: MakerDAO August 20, 2021 Executive Spell #179

Closed brianmcmichael closed 3 years ago

brianmcmichael commented 3 years ago

Description

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier
[x] Verify expiration (4 days monthly and 30 days for the rest)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

talbaneth commented 3 years ago

LGTM for deployment (already done)

talbaneth commented 3 years ago

LGTM for merge