makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

108 stars 45 forks source link

PE 637 - Adjust Ilk Liquidation Ratios #184

Closed WilfredTA closed 3 years ago

WilfredTA commented 3 years ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier
[ ] Verify expiration (4 days monthly and 30 days for the rest)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

brianmcmichael commented 3 years ago

Tests pass. Merging.