PE-673: Friday, September 17th Executive Spell

[julienmartinlevrai]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [ ] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [ ] squash and merge this PR

[brianmcmichael]

Be sure to update to the 0.0.8 mainnet release of DssExecLib https://github.com/makerdao/dss-exec-lib/releases/tag/v0.0.8

0xfd88cee74f7d78697775abdae53f9da1559728e4

Address will need to be changed in 4 places:

• [x] ./test-dssspell.sh
• [x] ./shell.nix
• [x] ./Makefile
• [x] ./README.md

[julienmartinlevrai]

dapp-test: rpc block: latest
Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7347)
[PASS] test_auth_in_sources() (gas: 281473904272923)
[PASS] test_use_eta() (gas: 321290)
[PASS] testOnTime() (gas: 2741257)
[PASS] test_nextCastTime() (gas: 389918)
[PASS] testFailTooEarly() (gas: 361000)
[PASS] test_bytecode_matches() (gas: 1487265)
[PASS] test_auth() (gas: 281473907933693)
[PASS] testSpellIsCast_GENERAL() (gas: 9314785)
[PASS] testKNCOffboarding() (gas: 2789512)
[PASS] testFailWrongDay() (gas: 361020)
[PASS] testCollateralIntegrations() (gas: 3686054)
[PASS] testCastCost() (gas: 2742945)
[PASS] testNewChainlogValues() (gas: 2754035)
[PASS] testNewIlkRegistryValues() (gas: 2761938)
[PASS] testFailTooLate() (gas: 361234)

[godsflaw]

Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7347)
[PASS] test_auth_in_sources() (gas: 281473904272923)
[PASS] test_use_eta() (gas: 321290)
[PASS] testOnTime() (gas: 2741257)
[PASS] test_nextCastTime() (gas: 389918)
[PASS] testFailTooEarly() (gas: 361000)
[PASS] test_bytecode_matches() (gas: 1487265)
[PASS] test_auth() (gas: 281473907933693)
[PASS] testSpellIsCast_GENERAL() (gas: 9314785)
[PASS] testKNCOffboarding() (gas: 2789512)
[PASS] testFailWrongDay() (gas: 361020)
[PASS] testCollateralIntegrations() (gas: 3686054)
[PASS] testCastCost() (gas: 2742945)
[PASS] testNewChainlogValues() (gas: 2754035)
[PASS] testNewIlkRegistryValues() (gas: 2761938)
[PASS] testFailTooLate() (gas: 361234)

[julienmartinlevrai]

tests with déployed spell

dapp-test: rpc block: latest
Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12347)
[PASS] test_auth_in_sources() (gas: 281473904272954)
[PASS] test_use_eta() (gas: 328290)
[PASS] testOnTime() (gas: 2750757)
[PASS] test_nextCastTime() (gas: 396918)
[PASS] testFailTooEarly() (gas: 368000)
[PASS] test_bytecode_matches() (gas: 1496765)
[PASS] test_auth() (gas: 281473907933724)
[PASS] testSpellIsCast_GENERAL() (gas: 10807709)
[PASS] testKNCOffboarding() (gas: 2799012)
[PASS] testFailWrongDay() (gas: 368020)
[PASS] testCollateralIntegrations() (gas: 3695554)
[PASS] testCastCost() (gas: 2752445)
[PASS] testNewChainlogValues() (gas: 2763535)
[PASS] testNewIlkRegistryValues() (gas: 2771438)
[PASS] testFailTooLate() (gas: 368234)

[godsflaw]

Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12347)
[PASS] test_auth_in_sources() (gas: 281473904272954)
[PASS] test_use_eta() (gas: 328290)
[PASS] testOnTime() (gas: 2750757)
[PASS] test_nextCastTime() (gas: 396918)
[PASS] testFailTooEarly() (gas: 368000)
[PASS] test_bytecode_matches() (gas: 1496765)
[PASS] test_auth() (gas: 281473907933724)
[PASS] testSpellIsCast_GENERAL() (gas: 10807709)
[PASS] testKNCOffboarding() (gas: 2799012)
[PASS] testFailWrongDay() (gas: 368020)
[PASS] testCollateralIntegrations() (gas: 3695554)
[PASS] testCastCost() (gas: 2752445)
[PASS] testNewChainlogValues() (gas: 2763535)
[PASS] testNewIlkRegistryValues() (gas: 2771438)
[PASS] testFailTooLate() (gas: 368234)