PE-678: MakerDAO September 24, 2021 Executive Spell

[naszam]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [x] squash and merge this PR

[gbalabasquer]

• buf decrements => ok
• hole increments => ok
• L2 addresses and code => to be confirmed by Kris
• Office hours on => ok
• 30 days expiration => ok
• Hash => ok
• Test local => running

[gbalabasquer]

Btw my local tests passes:

dapp-test: rpc block: latest
Running 12 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7236)
[PASS] test_auth_in_sources() (gas: 281473904308830)
[PASS] test_use_eta() (gas: 326591)
[PASS] testOnTime() (gas: 833674)
[PASS] test_nextCastTime() (gas: 389060)
[PASS] testFailTooEarly() (gas: 366219)
[PASS] test_bytecode_matches() (gas: 1124833)
[PASS] test_auth() (gas: 281473907965280)
[PASS] testSpellIsCast_GENERAL() (gas: 7141694)
[PASS] testFailWrongDay() (gas: 366217)
[PASS] testCastCost() (gas: 835472)
[PASS] testFailTooLate() (gas: 366392)

[brianmcmichael]

dapp-test: rpc block: latest
Running 12 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904308862)
[PASS] test_use_eta() (gas: 333591)
[PASS] testOnTime() (gas: 843174)
[PASS] test_nextCastTime() (gas: 396060)
[PASS] testFailTooEarly() (gas: 373219)
[PASS] test_bytecode_matches() (gas: 1134333)
[PASS] test_auth() (gas: 281473907965311)
[PASS] testSpellIsCast_GENERAL() (gas: 8273560)
[PASS] testFailWrongDay() (gas: 373217)
[PASS] testCastCost() (gas: 844972)
[PASS] testFailTooLate() (gas: 373392)