seth chain appears to always source from sethrc if it exports ETH_RPC_URL so we should use the --rpc-urlflag for seth chain This prevents hidden defaults.
Test case to show the issue:
define ETH_RPC_URL in your .sethrpc file.
in your terminal export ETH_RPC_URL=a
run make test
You should not get past the check for ETH_RPC_URL && $(seth chain) == "ethlive" but on the main branch you would and the tests will fail because a is not a valid URL.
My concern is that if we export an ETH_RPC_URL but also have one set in sethrc then seth chain would use the sethrc one. This change forces it to use the exported one which is the same thing we are doing for dapp when we actually run the tests.
Contribution Checklist
[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass
Checklist
[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier
[ ] Verify expiration (4 days monthly and 30 days for the rest)
Description
seth chainappears to always source from sethrc if it exportsETH_RPC_URLso we should use the--rpc-urlflag forseth chainThis prevents hidden defaults.Test case to show the issue:
ETH_RPC_URLin your.sethrpcfile.export ETH_RPC_URL=amake testETH_RPC_URL && $(seth chain) == "ethlive"but on the main branch you would and the tests will fail becauseais not a valid URL.My concern is that if we export an ETH_RPC_URL but also have one set in
sethrcthenseth chainwould use thesethrcone. This change forces it to use the exported one which is the same thing we are doing fordappwhen we actually run the tests.Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier4 daysmonthly and30 daysfor the rest)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanDssSpell.solandDssSpell.t.solthe same, but make a copy inarchivesquash and mergethis PR