PE-690: 2021-10-08 Executive Spell

[olivdb]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [x] squash and merge this PR

[olivdb]

Things to double check:

• in checkCollateralValues, we are checking that the mat of ilks currently offboarded via dss-lerp is between 1 RAY and the final mat value of the lerp. For all other ilks, we are keeping the previous check that the mat is in the range [1, 10[ RAY.

cc @godsflaw @brianmcmichael @gbalabasquer

[brianmcmichael]

Tests pass and seem sane. Values check out.

dapp-test: rpc block: latest
Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBATOffboardings() (gas: 3164119)
[PASS] testFail_notScheduled() (gas: 7258)
[PASS] testZRXOffboardings() (gas: 3164185)
[PASS] testLRCOffboardings() (gas: 3164207)
[PASS] test_auth_in_sources() (gas: 281473904320619)
[PASS] test_use_eta() (gas: 326657)
[PASS] testOnTime() (gas: 3115136)
[PASS] testUNIV2LINKETHOffboardings() (gas: 3164361)
[PASS] testOneTimeDaiDistribution() (gas: 3124147)
[PASS] test_nextCastTime() (gas: 389170)
[PASS] testFailTooEarly() (gas: 366329)
[PASS] test_bytecode_matches() (gas: 2027684)
[PASS] test_auth() (gas: 281473908008044)
[PASS] testSpellIsCast_GENERAL() (gas: 10210025)
[PASS] testFailWrongDay() (gas: 366327)
[PASS] testCastCost() (gas: 3116967)
[PASS] testVestMKR() (gas: 3192637)
[PASS] testNewChainlogValues() (gas: 3118737)
[PASS] testFailTooLate() (gas: 366546)
[PASS] testUNIV2AAVEETHOffboardings() (gas: 3164823)

LGTM for deploy