October 29th Executive

[talbaneth]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier
• [ ] Verify expiration (4 days monthly and 30 days for the rest)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
• [ ] squash and merge this PR

[talbaneth]

All tests pass on d0a03fd (before dc-iam use)

[talbaneth]

All tests pass.

[julienmartinlevrai]

0x9175561733D138326FDeA86CdFdF53e92b588276
└─ ward: MCD_PAUSE_PROXY

0xf1738d22140783707Ca71CB3746e0dc7Bf2b0264

0x99A219f3dD2DeEC02c6324df5009aaa60bA36d38
└─ owner: MCD_PAUSE_PROXY

0x028171bCA77440897B824Ca71D1c56caC55b68A3

0x6A858592fC4cBdf432Fc9A1Bc8A0422B99330bdF
└─ owner: MCD_PAUSE_PROXY

0xa13C0c8eB109F5A13c6c90FC26AFb23bEB3Fb04a
└─ ward: MCD_PAUSE_PROXY

0xa93b98e57dDe14A3E301f20933d59DC19BF8212E
└─ ward: MCD_PAUSE_PROXY

0x786DC9b69abeA503fd101a2A9fa95bcE82C20d0A
└─ ward: MCD_PAUSE_PROXY

[julienmartinlevrai]

[PASS] testFail_notScheduled() (gas: 4825)
[PASS] test_auth_in_sources() (gas: 281473904507458)
[PASS] test_use_eta() (gas: 321971)
[PASS] testOneTimePaymentDistributions() (gas: 2557184)
[PASS] testOnTime() (gas: 2543115)
[PASS] testVestDAI() (gas: 2758817)
[PASS] test_nextCastTime() (gas: 390269)
[PASS] testFailTooEarly() (gas: 355140)
[PASS] test_bytecode_matches() (gas: 1770393)
[PASS] test_auth() (gas: 281473909641659)
[PASS] testSpellIsCast_GENERAL() (gas: 9615636)
[PASS] testDirectMom() (gas: 3186003)
[PASS] testFailWrongDay() (gas: 355267)
[PASS] testCollateralIntegrations() (gas: 3216098)
[PASS] testCastCost() (gas: 2545900)
[PASS] testNewChainlogValues() (gas: 2548892)
[PASS] testNewIlkRegistryValues() (gas: 2562989)
[PASS] testFailTooLate() (gas: 355508)

[kmbarry1]

Tests passing for me at 721e72b.

[brianmcmichael]

Looks good for deploy at 665c94e0b901864de42e31f7516ee66e73049515

dapp-test: rpc block: latest
Running 18 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7325)
[PASS] test_auth_in_sources() (gas: 281473904536745)
[PASS] test_use_eta() (gas: 326971)
[PASS] testOneTimePaymentDistributions() (gas: 2735749)
[PASS] testOnTime() (gas: 2721680)
[PASS] testVestDAI() (gas: 2937373)
[PASS] test_nextCastTime() (gas: 395269)
[PASS] testFailTooEarly() (gas: 366747)
[PASS] test_bytecode_matches() (gas: 1844039)
[PASS] test_auth() (gas: 281473909667169)
[PASS] testSpellIsCast_GENERAL() (gas: 9964997)
[PASS] testDirectMom() (gas: 3364649)
[PASS] testFailWrongDay() (gas: 366767)
[PASS] testCollateralIntegrations() (gas: 3395737)
[PASS] testCastCost() (gas: 2724465)
[PASS] testNewChainlogValues() (gas: 2740495)
[PASS] testNewIlkRegistryValues() (gas: 2742524)
[PASS] testFailTooLate() (gas: 367008)

[talbaneth]

Tests pass:

Running 18 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7325) [PASS] test_auth_in_sources() (gas: 281473904536745) [PASS] test_use_eta() (gas: 326971) [PASS] testOneTimePaymentDistributions() (gas: 2735749) [PASS] testOnTime() (gas: 2721680) [PASS] testVestDAI() (gas: 2937373) [PASS] test_nextCastTime() (gas: 395269) [PASS] testFailTooEarly() (gas: 366747) [PASS] test_bytecode_matches() (gas: 1844039) [PASS] test_auth() (gas: 281473909667169) [PASS] testSpellIsCast_GENERAL() (gas: 9964997) [PASS] testDirectMom() (gas: 3364649) [PASS] testFailWrongDay() (gas: 366767) [PASS] testCollateralIntegrations() (gas: 3395737) [PASS] testCastCost() (gas: 2724465) [PASS] testNewChainlogValues() (gas: 2740495) [PASS] testNewIlkRegistryValues() (gas: 2742524) [PASS] testFailTooLate() (gas: 367008)

[julienmartinlevrai]

[PASS] testFail_notScheduled() (gas: 12325)
[PASS] test_auth_in_sources() (gas: 281473904536777)
[PASS] test_use_eta() (gas: 333971)
[PASS] testOneTimePaymentDistributions() (gas: 2743744)
[PASS] testOnTime() (gas: 2731180)
[PASS] testVestDAI() (gas: 2946873)
[PASS] test_nextCastTime() (gas: 402269)
[PASS] testFailTooEarly() (gas: 373747)
[PASS] test_bytecode_matches() (gas: 1853539)
[PASS] test_auth() (gas: 281473909667201)
[PASS] testSpellIsCast_GENERAL() (gas: 11813437)
[PASS] testDirectMom() (gas: 3374149)
[PASS] testFailWrongDay() (gas: 373767)
[PASS] testCollateralIntegrations() (gas: 3405237)
[PASS] testCastCost() (gas: 2733063)
[PASS] testNewChainlogValues() (gas: 2749995)
[PASS] testNewIlkRegistryValues() (gas: 2752024)
[PASS] testFailTooLate() (gas: 374008)

[talbaneth]

Tests pass also for me with deployed spell: Running 18 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12325) [PASS] test_auth_in_sources() (gas: 281473904536777) [PASS] test_use_eta() (gas: 333971) [PASS] testOneTimePaymentDistributions() (gas: 2743744) [PASS] testOnTime() (gas: 2731180) [PASS] testVestDAI() (gas: 2946873) [PASS] test_nextCastTime() (gas: 402269) [PASS] testFailTooEarly() (gas: 373747) [PASS] test_bytecode_matches() (gas: 1853539) [PASS] test_auth() (gas: 281473909667201) [PASS] testSpellIsCast_GENERAL() (gas: 11813437) [PASS] testDirectMom() (gas: 3374149) [PASS] testFailWrongDay() (gas: 373767) [PASS] testCollateralIntegrations() (gas: 3405237) [PASS] testCastCost() (gas: 2733063) [PASS] testNewChainlogValues() (gas: 2749995) [PASS] testNewIlkRegistryValues() (gas: 2752024) [PASS] testFailTooLate() (gas: 374008)

[brianmcmichael]

@dizzy @gbalabasquer can one of you update the RPC url in the secret list here?

[brianmcmichael]

I was able to get the secrets updated to a working RPC. CI is failing for a different reason now, potentially out of date dapptools? Tests run as expected locally. Going to approve for merge now, we should shore up CI for next week.