makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

108 stars 45 forks source link

PE-728 2021-11-05 Executive #199

Closed kmbarry1 closed 2 years ago

kmbarry1 commented 2 years ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier
[ ] Verify expiration (4 days monthly and 30 days for the rest)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Keep DssSpell.sol and DssSpell.t.sol the same, but make a copy in archive
[ ] squash and merge this PR

kmbarry1 commented 2 years ago

Looks like CI failures are just due to RPC call errors, not sure what we can do about that other than add caching and retry logic. Tests are passing locally for me.

talbaneth commented 2 years ago

LGTM for deployment pending the hash, tests pass:

Running 14 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7161) [PASS] testPsmParamChanges() (gas: 822092) [PASS] test_auth_in_sources() (gas: 281473904594559) [PASS] test_use_eta() (gas: 326753) [PASS] testOneTimePaymentDistributions() (gas: 827986) [PASS] testOnTime() (gas: 819412) [PASS] test_nextCastTime() (gas: 327626) [PASS] testFailTooEarly() (gas: 3550) [PASS] test_bytecode_matches() (gas: 1502954) [PASS] test_auth() (gas: 281473909816333) [PASS] testSpellIsCast_GENERAL() (gas: 7748245) [PASS] testFailWrongDay() (gas: 3550) [PASS] testCastCost() (gas: 820957) [PASS] testFailTooLate() (gas: 3527)

kmbarry1 commented 2 years ago

Link to executive copy and hash added.

kmbarry1 commented 2 years ago

Spell deployed, tests updated.

julienmartinlevrai commented 2 years ago

[PASS] testFail_notScheduled() (gas: 12236)
[PASS] testPsmParamChanges() (gas: 830484)
[PASS] test_auth_in_sources() (gas: 281473904579029)
[PASS] test_use_eta() (gas: 333453)
[PASS] testOneTimePaymentDistributions() (gas: 836103)
[PASS] testOnTime() (gas: 827924)
[PASS] test_nextCastTime() (gas: 334295)
[PASS] testFailTooEarly() (gas: 8479)
[PASS] test_bytecode_matches() (gas: 1239591)
[PASS] test_auth() (gas: 281473909709453)
[PASS] testSpellIsCast_GENERAL() (gas: 8655984)
[PASS] testFailWrongDay() (gas: 8633)
[PASS] testCastCost() (gas: 829722)
[PASS] testFailTooLate() (gas: 8787)

naszam commented 2 years ago

Test PASS (via HardHat Fork pinned at block n. 13557125)

dapp-test: rpc block: latest
Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] testPsmParamChanges() (gas: 829439)
[PASS] test_auth_in_sources() (gas: 281473904579029)
[PASS] test_use_eta() (gas: 333453)
[PASS] testOneTimePaymentDistributions() (gas: 835058)
[PASS] testOnTime() (gas: 826879)
[PASS] test_nextCastTime() (gas: 334295)
[PASS] testFailTooEarly() (gas: 8479)
[PASS] test_bytecode_matches() (gas: 1239591)
[PASS] test_auth() (gas: 281473909709453)
[PASS] testSpellIsCast_GENERAL() (gas: 8654939)
[PASS] testFailWrongDay() (gas: 8633)
[PASS] testCastCost() (gas: 828677)
[PASS] testFailTooLate() (gas: 8787)