PE-751: 2021-11-19 Executive

[naszam]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier
• [x] Verify expiration (4 days monthly and 30 days for the rest)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Run make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, and DssSpell.t.base.sol
• [x] squash and merge this PR

[gbalabasquer]

@naszam new max mats need to be set in the tests for LRC-A, BAT-A and ZRX-A

[gbalabasquer]

• MCD_JOIN_WBTC_B correctly created from known FAB and with the correct parameters
• MCD_CLIP_WBTC_B correctly created from known FAB and with the correct parameters
• MCD_CLIP_CALC_WBTC_B correctly created from known FAB and with the correct parameters
• WBTC-B onboarding risk params look good
• WBTC-A stability fee adjustment is ok
• AAVE-A offboarding is ok
• COMP-A offboarding is ok
• BAL-A offboarding is ok
• LRC-A replacement of mat lerp is ok
• BAT-A replacement of mat lerp is ok
• ZRX-A replacement of mat lerp is ok
• UNIV2LINKETH-A replacement of mat lerp is ok
• officeHours is off => ok
• 30 days is correctly set as expiration
• Tests pass
• Hash is correct

Spell is ready to be deployed

[gbalabasquer]

• Deployed spell corresponds to code and uses the correct deployed library 0xfD88CeE74f7D78697775aBDAE53f9Da1559728E4 - v0.0.8

[gbalabasquer]

@naszam I don't think I'll get the tests passing locally before having to be off for a while. So if you get confirmation the tests are passing I give my approval to share the spell address.

[naszam]

Test PASS (with deployed spell address at block n. 13646843):

dapp-test: rpc block: latest
Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBATIncreasedMatLerpOffboarding() (gas: 5324172)
[PASS] testFail_notScheduled() (gas: 12347)
[PASS] testLRCIncreasedMatLerpOffboarding() (gas: 5324238)
[PASS] test_auth_in_sources() (gas: 281473904573849)
[PASS] test_use_eta() (gas: 334015)
[PASS] testZRXIncreasedMatLerpOffboarding() (gas: 5324370)
[PASS] testOnTime() (gas: 5268536)
[PASS] test_nextCastTime() (gas: 402313)
[PASS] testFailTooEarly() (gas: 373791)
[PASS] testCOMPLerpOffboardings() (gas: 5317821)
[PASS] test_bytecode_matches() (gas: 2801218)
[PASS] testAAVELerpOffboardings() (gas: 5317909)
[PASS] test_auth() (gas: 281473909822607)
[PASS] testSpellIsCast_GENERAL() (gas: 16263988)
[PASS] testFailWrongDay() (gas: 373855)
[PASS] testCollateralIntegrations() (gas: 6179488)
[PASS] testCastCost() (gas: 5270452)
[PASS] testUNIV2LINKETHIncreasedMatLerpOffboarding() (gas: 5324854)
[PASS] testNewChainlogValues() (gas: 5279316)
[PASS] testNewIlkRegistryValues() (gas: 5289530)
[PASS] testBALLerpOffboardings() (gas: 5318217)
[PASS] testFailTooLate() (gas: 374140)

[gbalabasquer]

Tests passed locally:

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBATIncreasedMatLerpOffboarding() (gas: 5324172)
[PASS] testFail_notScheduled() (gas: 12347)
[PASS] testLRCIncreasedMatLerpOffboarding() (gas: 5324238)
[PASS] test_auth_in_sources() (gas: 281473904573849)
[PASS] test_use_eta() (gas: 334015)
[PASS] testZRXIncreasedMatLerpOffboarding() (gas: 5324370)
[PASS] testOnTime() (gas: 5268536)
[PASS] test_nextCastTime() (gas: 402313)
[PASS] testFailTooEarly() (gas: 373791)
[PASS] testCOMPLerpOffboardings() (gas: 5317821)
[PASS] test_bytecode_matches() (gas: 2801218)
[PASS] testAAVELerpOffboardings() (gas: 5317909)
[PASS] test_auth() (gas: 281473909822607)
[PASS] testSpellIsCast_GENERAL() (gas: 16263988)
[PASS] testFailWrongDay() (gas: 373855)
[PASS] testCollateralIntegrations() (gas: 6179488)
[PASS] testCastCost() (gas: 5270452)
[PASS] testUNIV2LINKETHIncreasedMatLerpOffboarding() (gas: 5324854)
[PASS] testNewChainlogValues() (gas: 5279316)
[PASS] testNewIlkRegistryValues() (gas: 5289530)
[PASS] testBALLerpOffboardings() (gas: 5318217)
[PASS] testFailTooLate() (gas: 374140)

Please archive and will give the approval. But so far the spell can be sent to GovAlpha.