makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
108 stars 45 forks source link

PE-766: 2021/12/3 Executive #208

Closed WilfredTA closed 2 years ago

WilfredTA commented 2 years ago

Description

Contribution Checklist

Checklist

julienmartinlevrai commented 2 years ago

Tests pass. Looks good for déployment.

julienmartinlevrai commented 2 years ago

Tests with déployed spell pass. Contract is vérified and its code matches the flattened version.

julienmartinlevrai commented 2 years ago

Looks good for archiving

iamchrissmith commented 2 years ago

Tests pass at block 13754536 Checked deployed/verified spell Deployed Spell Code Matches GitHub Diffcheck DssExecLib v0.0.8

Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12325)
[PASS] test_auth_in_sources() (gas: 281473904600641)
[PASS] test_use_eta() (gas: 333971)
[PASS] testOneTimePaymentDistributions() (gas: 3662699)
[PASS] testOnTime() (gas: 3644224)
[PASS] test_nextCastTime() (gas: 402269)
[PASS] testFailTooEarly() (gas: 373747)
[PASS] test_bytecode_matches() (gas: 2331256)
[PASS] test_auth() (gas: 281473910283132)
[PASS] testSpellIsCast_GENERAL() (gas: 13783174)
[PASS] testFailWrongDay() (gas: 373817)
[PASS] testCollateralIntegrations() (gas: 4597331)
[PASS] testCastCost() (gas: 3646118)
[PASS] testNewChainlogValues() (gas: 3659414)
[PASS] testNewIlkRegistryValues() (gas: 3665925)
[PASS] testFailTooLate() (gas: 374124)