search

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
108 stars 45 forks source link

add a collateral offboarding flag #211

Closed iamchrissmith closed 2 years ago

iamchrissmith commented 2 years ago

Replaces the hard coded list of collateral that are being offboarded with an attribute in the collateral definitions.

brianmcmichael commented 2 years ago

You'll want to update these PR's to remove the deployed_spell so the tests can pass.

iamchrissmith commented 2 years ago

@godsflaw @gbalabasquer @brianmcmichael this is a change that @naszam and I discussed to get rid of the hard coded collateral offboarding ilks. Would love your thoughts on this and if you think a offboarding value is the right approach or if we need a more nuanced status system (i.e. onboarded, offboarding, offboarded) (see original comment https://github.com/makerdao/spells-mainnet/pull/210#discussion_r771592829)

iamchrissmith commented 2 years ago

image

tests passing locally pinned to block before last spell cast after lerping change

iamchrissmith commented 2 years ago

lerp change tests pass locally:

image