Closed brianmcmichael closed 2 years ago
looking good initially, tests pass from the block for last week's spell (before rates were removed)
dapp-test: rpc block: latest
Running 12 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 4661)
[PASS] test_auth_in_sources() (gas: 281473904849513)
[PASS] test_use_eta() (gas: 177138)
[PASS] testOnTime() (gas: 237581)
[PASS] test_nextCastTime() (gas: 178011)
[PASS] testFailTooEarly() (gas: 3595)
[PASS] test_bytecode_matches() (gas: 1087096)
[PASS] test_auth() (gas: 281473913181236)
[PASS] testSpellIsCast_GENERAL() (gas: 7313316)
[PASS] testFailWrongDay() (gas: 3550)
[PASS] testCastCost() (gas: 240070)
[PASS] testFailTooLate() (gas: 3527)
@brianmcmichael we might want a test to show that the SB lerp fails after the spell is cast and can not override values.
tests pass:
dapp-test: rpc block: latest Running 13 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7236) [PASS] test_auth_in_sources() (gas: 281473904834420) [PASS] test_use_eta() (gas: 326431) [PASS] testOnTime() (gas: 393341) [PASS] test_nextCastTime() (gas: 327273) [PASS] testFailTooEarly() (gas: 3457) [PASS] test_bytecode_matches() (gas: 908350) [PASS] test_auth() (gas: 281473912919904) [PASS] testSpellIsCast_GENERAL() (gas: 7328336) [PASS] testFailWrongDay() (gas: 3677) [PASS] testCastCost() (gas: 396077) [PASS] testLerps() (gas: 399845) [PASS] testFailTooLate() (gas: 3853)
I wrote the spell so it doesn't matter, but getting green beans on the deployed spell.
dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904834452)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 402841)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 917850)
[PASS] test_auth() (gas: 281473912919935)
[PASS] testSpellIsCast_GENERAL() (gas: 8244395)
[PASS] testFailWrongDay() (gas: 8677)
[PASS] testCastCost() (gas: 404705)
[PASS] testLerps() (gas: 424030)
[PASS] testFailTooLate() (gas: 8853)
pre-deployment tests pass:
dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7236)
[PASS] test_auth_in_sources() (gas: 281473904834420)
[PASS] test_use_eta() (gas: 326431)
[PASS] testOnTime() (gas: 393341)
[PASS] test_nextCastTime() (gas: 327273)
[PASS] testFailTooEarly() (gas: 3457)
[PASS] test_bytecode_matches() (gas: 908350)
[PASS] test_auth() (gas: 281473912919904)
[PASS] testSpellIsCast_GENERAL() (gas: 7328336)
[PASS] testFailWrongDay() (gas: 3677)
[PASS] testCastCost() (gas: 395205)
[PASS] testLerps() (gas: 399845)
[PASS] testFailTooLate() (gas: 3853)
post deployment tests at block 14070672
dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904834452)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 402841)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 917850)
[PASS] test_auth() (gas: 281473912919935)
[PASS] testSpellIsCast_GENERAL() (gas: 8244395)
[PASS] testFailWrongDay() (gas: 8677)
[PASS] testCastCost() (gas: 404705)
[PASS] testLerps() (gas: 426380)
[PASS] testFailTooLate() (gas: 8853)
hash confirmed, verified on etherscan, should be ready to archive and then merge
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR