PE-829 Emergency Executive

[brianmcmichael]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[iamchrissmith]

looking good initially, tests pass from the block for last week's spell (before rates were removed)

dapp-test: rpc block: latest
Running 12 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 4661)
[PASS] test_auth_in_sources() (gas: 281473904849513)
[PASS] test_use_eta() (gas: 177138)
[PASS] testOnTime() (gas: 237581)
[PASS] test_nextCastTime() (gas: 178011)
[PASS] testFailTooEarly() (gas: 3595)
[PASS] test_bytecode_matches() (gas: 1087096)
[PASS] test_auth() (gas: 281473913181236)
[PASS] testSpellIsCast_GENERAL() (gas: 7313316)
[PASS] testFailWrongDay() (gas: 3550)
[PASS] testCastCost() (gas: 240070)
[PASS] testFailTooLate() (gas: 3527)

[talbaneth]

@brianmcmichael we might want a test to show that the SB lerp fails after the spell is cast and can not override values.

[talbaneth]

tests pass:

dapp-test: rpc block: latest Running 13 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7236) [PASS] test_auth_in_sources() (gas: 281473904834420) [PASS] test_use_eta() (gas: 326431) [PASS] testOnTime() (gas: 393341) [PASS] test_nextCastTime() (gas: 327273) [PASS] testFailTooEarly() (gas: 3457) [PASS] test_bytecode_matches() (gas: 908350) [PASS] test_auth() (gas: 281473912919904) [PASS] testSpellIsCast_GENERAL() (gas: 7328336) [PASS] testFailWrongDay() (gas: 3677) [PASS] testCastCost() (gas: 396077) [PASS] testLerps() (gas: 399845) [PASS] testFailTooLate() (gas: 3853)

[brianmcmichael]

I wrote the spell so it doesn't matter, but getting green beans on the deployed spell.

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904834452)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 402841)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 917850)
[PASS] test_auth() (gas: 281473912919935)
[PASS] testSpellIsCast_GENERAL() (gas: 8244395)
[PASS] testFailWrongDay() (gas: 8677)
[PASS] testCastCost() (gas: 404705)
[PASS] testLerps() (gas: 424030)
[PASS] testFailTooLate() (gas: 8853)

[iamchrissmith]

pre-deployment tests pass:

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7236)
[PASS] test_auth_in_sources() (gas: 281473904834420)
[PASS] test_use_eta() (gas: 326431)
[PASS] testOnTime() (gas: 393341)
[PASS] test_nextCastTime() (gas: 327273)
[PASS] testFailTooEarly() (gas: 3457)
[PASS] test_bytecode_matches() (gas: 908350)
[PASS] test_auth() (gas: 281473912919904)
[PASS] testSpellIsCast_GENERAL() (gas: 7328336)
[PASS] testFailWrongDay() (gas: 3677)
[PASS] testCastCost() (gas: 395205)
[PASS] testLerps() (gas: 399845)
[PASS] testFailTooLate() (gas: 3853)

[iamchrissmith]

post deployment tests at block 14070672

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904834452)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 402841)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 917850)
[PASS] test_auth() (gas: 281473912919935)
[PASS] testSpellIsCast_GENERAL() (gas: 8244395)
[PASS] testFailWrongDay() (gas: 8677)
[PASS] testCastCost() (gas: 404705)
[PASS] testLerps() (gas: 426380)
[PASS] testFailTooLate() (gas: 8853)

[iamchrissmith]

hash confirmed, verified on etherscan, should be ready to archive and then merge