Closed brianmcmichael closed 2 years ago
Finished reviewing current code, looks good, minor comments only. Tests pass.
Tests pass:
Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7161) [PASS] testYankedDaiStreams() (gas: 1721766) [PASS] test_auth_in_sources() (gas: 281473904858257) [PASS] test_use_eta() (gas: 326731) [PASS] testOnTime() (gas: 1713693) [PASS] testVestDAI() (gas: 2375723) [PASS] test_nextCastTime() (gas: 327693) [PASS] testFailTooEarly() (gas: 3528) [PASS] test_bytecode_matches() (gas: 1893885) [PASS] test_auth() (gas: 281473913192377) [PASS] testSpellIsCast_GENERAL() (gas: 9701926) [PASS] testFailWrongDay() (gas: 3550) [PASS] testCastCost() (gas: 1715282) [PASS] testVestMKR() (gas: 1905912) [PASS] testPayouts() (gas: 1728695) [PASS] testFailTooLate() (gas: 3549)
Hash matches, tests pass: Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4661) [PASS] testYankedDaiStreams() (gas: 1719311) [PASS] test_auth_in_sources() (gas: 281473904854257) [PASS] test_use_eta() (gas: 324231) [PASS] testOnTime() (gas: 1711238) [PASS] testVestDAI() (gas: 2373268) [PASS] test_nextCastTime() (gas: 325238) [PASS] testFailTooEarly() (gas: 3618) [PASS] test_bytecode_matches() (gas: 1997745) [PASS] test_auth() (gas: 281473913188377) [PASS] testSpellIsCast_GENERAL() (gas: 9804414) [PASS] testFailWrongDay() (gas: 3640) [PASS] testCastCost() (gas: 1712827) [PASS] testVestMKR() (gas: 1903457) [PASS] testPayouts() (gas: 1726240) [PASS] testFailTooLate() (gas: 3639)
Test pass with deployed spell: Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12161) [PASS] testYankedDaiStreams() (gas: 1731311) [PASS] test_auth_in_sources() (gas: 281473904858288) [PASS] test_use_eta() (gas: 333731) [PASS] testOnTime() (gas: 1723238) [PASS] testVestDAI() (gas: 2385268) [PASS] test_nextCastTime() (gas: 334738) [PASS] testFailTooEarly() (gas: 8618) [PASS] test_bytecode_matches() (gas: 2013745) [PASS] test_auth() (gas: 281473913192408) [PASS] testSpellIsCast_GENERAL() (gas: 11813099) [PASS] testFailWrongDay() (gas: 8640) [PASS] testCastCost() (gas: 1724827) [PASS] testVestMKR() (gas: 1915457) [PASS] testPayouts() (gas: 1738240) [PASS] testFailTooLate() (gas: 8639)
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR