makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

106 stars 45 forks source link

PE-837 Friday, January 28, 2022 MakerDAO Executive Spell #217

Closed brianmcmichael closed 2 years ago

brianmcmichael commented 2 years ago

Description

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[x] Code approved
[x] Tests approved
[x] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier override
[x] Verify expiration (30 days unless otherwise specified)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

talbaneth commented 2 years ago

Finished reviewing current code, looks good, minor comments only. Tests pass.

talbaneth commented 2 years ago

Tests pass:

Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 7161) [PASS] testYankedDaiStreams() (gas: 1721766) [PASS] test_auth_in_sources() (gas: 281473904858257) [PASS] test_use_eta() (gas: 326731) [PASS] testOnTime() (gas: 1713693) [PASS] testVestDAI() (gas: 2375723) [PASS] test_nextCastTime() (gas: 327693) [PASS] testFailTooEarly() (gas: 3528) [PASS] test_bytecode_matches() (gas: 1893885) [PASS] test_auth() (gas: 281473913192377) [PASS] testSpellIsCast_GENERAL() (gas: 9701926) [PASS] testFailWrongDay() (gas: 3550) [PASS] testCastCost() (gas: 1715282) [PASS] testVestMKR() (gas: 1905912) [PASS] testPayouts() (gas: 1728695) [PASS] testFailTooLate() (gas: 3549)

talbaneth commented 2 years ago

Hash matches, tests pass: Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4661) [PASS] testYankedDaiStreams() (gas: 1719311) [PASS] test_auth_in_sources() (gas: 281473904854257) [PASS] test_use_eta() (gas: 324231) [PASS] testOnTime() (gas: 1711238) [PASS] testVestDAI() (gas: 2373268) [PASS] test_nextCastTime() (gas: 325238) [PASS] testFailTooEarly() (gas: 3618) [PASS] test_bytecode_matches() (gas: 1997745) [PASS] test_auth() (gas: 281473913188377) [PASS] testSpellIsCast_GENERAL() (gas: 9804414) [PASS] testFailWrongDay() (gas: 3640) [PASS] testCastCost() (gas: 1712827) [PASS] testVestMKR() (gas: 1903457) [PASS] testPayouts() (gas: 1726240) [PASS] testFailTooLate() (gas: 3639)

talbaneth commented 2 years ago

Test pass with deployed spell: Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12161) [PASS] testYankedDaiStreams() (gas: 1731311) [PASS] test_auth_in_sources() (gas: 281473904858288) [PASS] test_use_eta() (gas: 333731) [PASS] testOnTime() (gas: 1723238) [PASS] testVestDAI() (gas: 2385268) [PASS] test_nextCastTime() (gas: 334738) [PASS] testFailTooEarly() (gas: 8618) [PASS] test_bytecode_matches() (gas: 2013745) [PASS] test_auth() (gas: 281473913192408) [PASS] testSpellIsCast_GENERAL() (gas: 11813099) [PASS] testFailWrongDay() (gas: 8640) [PASS] testCastCost() (gas: 1724827) [PASS] testVestMKR() (gas: 1915457) [PASS] testPayouts() (gas: 1738240) [PASS] testFailTooLate() (gas: 8639)