talbaneth commented 2 years ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier override
[ ] Verify expiration (30 days unless otherwise specified)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

brianmcmichael commented 2 years ago

Diffcheck on ESM at 0x09e05fF6142F2f9de8B6B65855A1d56B6cfE4c58 looks good. https://www.diffchecker.com/9wJhCMIr

gbalabasquer commented 2 years ago

Rates declared in spell match rates contract values
Delegates Wallets declared in spell match wallets contract values and the ones in the doc
Delegates payments are matching the doc
CU Wallets declared in spell match wallets contract values and the ones in the doc
CU payouts February payouts match the doc
Yanked vests are the correct ones
New vests match the doc
ESM deployed contract matches repo hash 225ddf29b1515d10ea6d4f9cde5814a73085ce09
ESM.end matches with END
ESM.gem matches with MKR
ESM.min is 100K MKR (and re set to it)
ESM.proxy matches with PAUSE_PROXY
ESM: Deployer correctly denied
Stability fee descreases match doc
AAVE target borrow rate matches doc
GUNI auto line changes match the doc
Office hours correctly set to on
30 days expiration is correct

Tests look good and passed

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 4647)
[PASS] test_auth_in_sources() (gas: 281473904635554)
[PASS] test_use_eta() (gas: 324444)
[PASS] testOnTime() (gas: 3943030)
[PASS] testPayments() (gas: 3974442)
[PASS] testVestDAI() (gas: 4163170)
[PASS] testVestDAINotBlocking() (gas: 4345657)
[PASS] test_nextCastTime() (gas: 386878)
[PASS] testFailTooEarly() (gas: 364354)
[PASS] test_bytecode_matches() (gas: 7991473)
[PASS] testFailFireESM() (gas: 4058160)
[PASS] testAAVEDirectBarChange() (gas: 3946705)
[PASS] test_auth() (gas: 281473912971562)
[PASS] testSpellIsCast_GENERAL() (gas: 17641244)
[PASS] testFailWrongDay() (gas: 364262)
[PASS] testCastCost() (gas: 3944553)
[PASS] testESMOffboarding() (gas: 281473910151389)
[PASS] testNewChainlogValues() (gas: 3949052)
[PASS] testFireESM() (gas: 4261420)
[PASS] testFailTooLate() (gas: 364283)

Whenever hash is ready and approved we should be fine for deploying

talbaneth commented 2 years ago

Test pass with optimizations on: dapp-test: rpc block: latest Running 20 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4714) [PASS] test_auth_in_sources() (gas: 281473904611167) [PASS] test_use_eta() (gas: 324069) [PASS] testOnTime() (gas: 3947505) [PASS] testPayments() (gas: 3977733) [PASS] testVestDAI() (gas: 4166732) [PASS] testVestDAINotBlocking() (gas: 4349250) [PASS] test_nextCastTime() (gas: 386252) [PASS] testFailTooEarly() (gas: 363807) [PASS] test_bytecode_matches() (gas: 6744156) [PASS] testFailFireESM() (gas: 4060658) [PASS] testAAVEDirectBarChange() (gas: 3951365) [PASS] test_auth() (gas: 281473912700813) [PASS] testSpellIsCast_GENERAL() (gas: 16334477) [PASS] testFailWrongDay() (gas: 363915) [PASS] testCastCost() (gas: 3949468) [PASS] testESMOffboarding() (gas: 281473910131786) [PASS] testNewChainlogValues() (gas: 3954040) [PASS] testFireESM() (gas: 4263764) [PASS] testFailTooLate() (gas: 364156)

talbaneth commented 2 years ago

tests pass:dapp-test: rpc block: latest Running 20 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 4647) [PASS] test_auth_in_sources() (gas: 281473904635523) [PASS] test_use_eta() (gas: 324444) [PASS] testOnTime() (gas: 3954760) [PASS] testPayments() (gas: 3986172) [PASS] testVestDAI() (gas: 4174900) [PASS] testVestDAINotBlocking() (gas: 4357387) [PASS] test_nextCastTime() (gas: 386878) [PASS] testFailTooEarly() (gas: 364461) [PASS] test_bytecode_matches() (gas: 3498471) [PASS] testFailFireESM() (gas: 4067890) [PASS] testAAVEDirectBarChange() (gas: 3958435) [PASS] test_auth() (gas: 281473912971531) [PASS] testSpellIsCast_GENERAL() (gas: 13178749) [PASS] testFailWrongDay() (gas: 364262) [PASS] testCastCost() (gas: 3956283) [PASS] testESMOffboarding() (gas: 281473910161119) [PASS] testNewChainlogValues() (gas: 3960782) [PASS] testFireESM() (gas: 4271150) [PASS] testFailTooLate() (gas: 364283)

brianmcmichael commented 2 years ago

I think we've cracked this nut.

$ ./estimate-deploy-gas.sh 
3788048

brianmcmichael commented 2 years ago

dapp-test: rpc block: latest
Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 4647)
[PASS] test_auth_in_sources() (gas: 281473904635523)
[PASS] test_use_eta() (gas: 324444)
[PASS] testOnTime() (gas: 3954760)
[PASS] testPayments() (gas: 3986172)
[PASS] testVestDAI() (gas: 4174900)
[PASS] testVestDAINotBlocking() (gas: 4357387)
[PASS] test_nextCastTime() (gas: 386878)
[PASS] testFailTooEarly() (gas: 364461)
[PASS] test_bytecode_matches() (gas: 3498471)
[PASS] testFailFireESM() (gas: 4067890)
[PASS] testAAVEDirectBarChange() (gas: 3958435)
[PASS] test_auth() (gas: 281473912971531)
[PASS] testSpellIsCast_GENERAL() (gas: 13178749)
[PASS] testFailWrongDay() (gas: 364262)
[PASS] testCastCost() (gas: 3956283)
[PASS] testESMOffboarding() (gas: 281473910161119)
[PASS] testNewChainlogValues() (gas: 3960782)
[PASS] testFireESM() (gas: 4271150)
[PASS] testFailTooLate() (gas: 364283)

talbaneth commented 2 years ago

tests pass with deployed spell on 77e1ad31c:

Running 20 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12147) [PASS] test_auth_in_sources() (gas: 281473904637555) [PASS] test_use_eta() (gas: 333944) [PASS] testOnTime() (gas: 3974875) [PASS] testPayments() (gas: 4006287) [PASS] testVestDAI() (gas: 4195015) [PASS] testVestDAINotBlocking() (gas: 4377502) [PASS] test_nextCastTime() (gas: 396378) [PASS] testFailTooEarly() (gas: 373961) [PASS] test_bytecode_matches() (gas: 3520471) [PASS] testFailFireESM() (gas: 4088005) [PASS] testAAVEDirectBarChange() (gas: 3978550) [PASS] test_auth() (gas: 281473912973563) [PASS] testSpellIsCast_GENERAL() (gas: 16688889) [PASS] testFailWrongDay() (gas: 373762) [PASS] testCastCost() (gas: 3976398) [PASS] testESMOffboarding() (gas: 281473910172859) [PASS] testNewChainlogValues() (gas: 3980897) [PASS] testFireESM() (gas: 4291265) [PASS] testFailTooLate() (gas: 373783)

talbaneth commented 2 years ago

tests pass with deployed spell also in f71265d:

Running 20 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testFail_notScheduled() (gas: 12147) [PASS] test_auth_in_sources() (gas: 281473904637555) [PASS] test_use_eta() (gas: 333944) [PASS] testOnTime() (gas: 3974980) [PASS] testPayments() (gas: 4006392) [PASS] testVestDAI() (gas: 4195120) [PASS] testVestDAINotBlocking() (gas: 4385325) [PASS] test_nextCastTime() (gas: 396378) [PASS] testFailTooEarly() (gas: 373961) [PASS] test_bytecode_matches() (gas: 3520471) [PASS] testFailFireESM() (gas: 4088110) [PASS] testAAVEDirectBarChange() (gas: 3978655) [PASS] test_auth() (gas: 281473912973563) [PASS] testSpellIsCast_GENERAL() (gas: 16688994) [PASS] testFailWrongDay() (gas: 373762) [PASS] testCastCost() (gas: 3976503) [PASS] testESMOffboarding() (gas: 281473910172964) [PASS] testNewChainlogValues() (gas: 3981002) [PASS] testFireESM() (gas: 4291370) [PASS] testFailTooLate() (gas: 373783)

gbalabasquer commented 2 years ago

Tests passing here as well:

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12147)
[PASS] test_auth_in_sources() (gas: 281473904637555)
[PASS] test_use_eta() (gas: 333944)
[PASS] testOnTime() (gas: 3974760)
[PASS] testPayments() (gas: 4006172)
[PASS] testVestDAI() (gas: 4194900)
[PASS] testVestDAINotBlocking() (gas: 4385105)
[PASS] test_nextCastTime() (gas: 396378)
[PASS] testFailTooEarly() (gas: 373961)
[PASS] test_bytecode_matches() (gas: 3520471)
[PASS] testFailFireESM() (gas: 4087890)
[PASS] testAAVEDirectBarChange() (gas: 3978435)
[PASS] test_auth() (gas: 281473912973563)
[PASS] testSpellIsCast_GENERAL() (gas: 16692131)
[PASS] testFailWrongDay() (gas: 373762)
[PASS] testCastCost() (gas: 3976283)
[PASS] testESMOffboarding() (gas: 281473910172744)
[PASS] testNewChainlogValues() (gas: 3980782)
[PASS] testFireESM() (gas: 4291150)
[PASS] testFailTooLate() (gas: 373783)

makerdao / spells-mainnet

PE-849 Feb 4th Executive Spell #218

Description

Contribution Checklist

Checklist