PE-878: 2022-03-11 Executive

[hexonaut]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[gbalabasquer]

Please merge this from master. Otherwise it won't be actually testing from deployed spell when the address is added (so quite important fix).

[brianmcmichael]

Per GovOps this week the plan is:

• Rate Limited Flapper
• Curve STETH Pool
• Immunifi Bug Bounty Payouts

[hexonaut]

Ready for review. This is a big one. I would suggest starting right away to review.

[talbaneth]

Finished pass on DssSpellCollateralOnboarding.sol and Cropper related tests. Looks good, see above comments.

[talbaneth]

For the record these are the checks I'v done (only curve lp related stuff):

• CdpRegistry:

  • code matches repo.
  • cdp manager ctr param ok.
  • no relies/denies needed.

• PROXY_ACTIONS_CROPPER:

  • code matches repo.
  • ctr params ok.
  • no relies/denies needed.

• PROXY_ACTIONS_END_CROPPER:

  • code matches repo.
  • ctr params ok.
  • no relies/denies needed.

• CROPPER:

  • code matches repo.
  • no ctr params.
  • rely/deny ok.
  • implementation set to the right contract.

• CROPPER_IMP:

  • code matches repo.
  • vat ctr param ok.
  • no relies/denies needed.

• ETHSTETH:

  • correct token.

• PIP_ETHSTETH:

  • code matches repo.
  • ctr params ok.
  • rely/deny ok.

• MCD_JOIN_ETHSTETH_A:

  • code matches repo.
  • no ctr params.
  • rely/deny ok (events problem)
  • implementation set correctly.

• SynthetixJoinImp (not in the spell) - 0x9C62538CF4aADF8021D00558a2DC3C8C3e99f58e:

  • code matches repo.
  • ctr params ok.
  • no relies/denies needed.

• MCD_CLIP_ETHSTETH_A:

  • code matches repo.
  • ctr params ok.
  • rely/deny ok.

• MCD_CLIP_CALC_ETHSTETH_A:

  • code matches repo.
  • no ctr params.
  • rely/deny ok.

• STETH_PRICE:

  • code matches repo.
  • ctr params ok.
  • rely/deny ok.

• WSTETH_MEDIAN:

  • correct contract.

• addNewCollateral params:

  • minVaultAmount not updated with the forum post - fixed.
  • debt ceiling not updated with the forum post - fixed.

• setStairstepExponentialDecrease and setIlkAutoLineParameters ok.

• auths and whitelists - ok.

• ChainLog Updates:

  • consider adding SynthetixJoinImp - decided not to.

• checkCropCRVLPIntegration ok

.............

Tests pass on 4080f87