Closed hexonaut closed 2 years ago
Please merge this from master. Otherwise it won't be actually testing from deployed spell when the address is added (so quite important fix).
Per GovOps this week the plan is:
Ready for review. This is a big one. I would suggest starting right away to review.
Finished pass on DssSpellCollateralOnboarding.sol and Cropper related tests. Looks good, see above comments.
For the record these are the checks I'v done (only curve lp related stuff):
CdpRegistry:
PROXY_ACTIONS_CROPPER:
PROXY_ACTIONS_END_CROPPER:
CROPPER:
CROPPER_IMP:
ETHSTETH:
PIP_ETHSTETH:
MCD_JOIN_ETHSTETH_A:
SynthetixJoinImp (not in the spell) - 0x9C62538CF4aADF8021D00558a2DC3C8C3e99f58e:
MCD_CLIP_ETHSTETH_A:
MCD_CLIP_CALC_ETHSTETH_A:
STETH_PRICE:
WSTETH_MEDIAN:
addNewCollateral params:
setStairstepExponentialDecrease and setIlkAutoLineParameters ok.
auths and whitelists - ok.
ChainLog Updates:
checkCropCRVLPIntegration ok
.............
Tests pass on 4080f87
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR