PE-933 Executive Spell April 1, 2022

[iamchrissmith]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[godsflaw]

LGTM

Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 1202607)
[PASS] testFailTooEarly() (gas: 12594)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12572)
[PASS] testFail_notScheduled() (gas: 14161)
[PASS] testOnTime() (gas: 1199771)
[PASS] testOneTimeMkrDistributions() (gas: 1206578)
[PASS] testOneTimePaymentDistributions() (gas: 1230166)
[PASS] testSpellIsCast_GENERAL() (gas: 13107175)
[PASS] testVestDAI() (gas: 1251646)
[PASS] testVestMKR() (gas: 1229994)
[PASS] test_bytecode_matches() (gas: 1850021)
[PASS] test_nextCastTime() (gas: 338922)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 14 passed; 0 failed; finished in 9.43s