Closed godsflaw closed 2 years ago
Naz noticed that the GELATO_STREAMING
address ended up in ./src/test/addresses_mainnet.sol
last week. This file should roughly map to what's in the on-chain changelog, so we should move this address to ./src/test/addresses_wallet.sol
and fix any references.
Naz noticed that the
GELATO_STREAMING
address ended up in./src/test/addresses_mainnet.sol
last week. This file should roughly map to what's in the on-chain changelog, so we should move this address to./src/test/addresses_wallet.sol
and fix any references.
i've created this to fix this issue: https://github.com/makerdao/spells-mainnet/pull/238
good spot @naszam !
This PR now waiting on goerli
: https://github.com/makerdao/spells-goerli/pull/66
Ready for review
Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 1215844)
[PASS] testCastCost() (gas: 1209323)
[PASS] testFailTooEarly() (gas: 12572)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 1205734)
[PASS] testPayments() (gas: 1239758)
[PASS] testSpellIsCast_GENERAL() (gas: 11082810)
[PASS] test_auth() (gas: 9223336852493024829)
[PASS] test_auth_in_sources() (gas: 9223336852484404070)
[PASS] test_bytecode_matches() (gas: 1666433)
[PASS] test_nextCastTime() (gas: 338900)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 14 passed; 0 failed; finished in 12.84s
Full checklist pre-deploy review:
pragma experimental ABIEncoderV2;
bc -l <<< 'scale=27; e( l(1.0X)/(60 * 60 * 24 * 365) )'
(replace X with %, e.g. 1 = 1%)Ready for final review with deployed spell address and archive:
Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12139)
[PASS] test_auth_in_sources() (gas: 281473904945375)
[PASS] test_use_eta() (gas: 336955)
[PASS] testOnTime() (gas: 1320693)
[PASS] testPayments() (gas: 1348717)
[PASS] test_nextCastTime() (gas: 337900)
[PASS] testFailTooEarly() (gas: 8572)
[PASS] test_bytecode_matches() (gas: 1693354)
[PASS] testAAVEDirectBarChange() (gas: 1324303)
[PASS] test_auth() (gas: 281473913566549)
[PASS] testSpellIsCast_GENERAL() (gas: 10819551)
[PASS] testFailWrongDay() (gas: 8594)
[PASS] testCastCost() (gas: 1322282)
[PASS] testFailTooLate() (gas: 8549)
CI is failing likely due to timeout on auth tests.
We can remove them now and add them back in when CI is upgraded to foundry.
Description
April 8th Executive Spell
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR