PE-947: April 8th Executive Spell

[godsflaw]

Description

April 8th Executive Spell

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[brianmcmichael]

Naz noticed that the GELATO_STREAMING address ended up in ./src/test/addresses_mainnet.sol last week. This file should roughly map to what's in the on-chain changelog, so we should move this address to ./src/test/addresses_wallet.sol and fix any references.

[iamchrissmith]

Naz noticed that the GELATO_STREAMING address ended up in ./src/test/addresses_mainnet.sol last week. This file should roughly map to what's in the on-chain changelog, so we should move this address to ./src/test/addresses_wallet.sol and fix any references.

i've created this to fix this issue: https://github.com/makerdao/spells-mainnet/pull/238

good spot @naszam !

[godsflaw]

This PR now waiting on goerli: https://github.com/makerdao/spells-goerli/pull/66

[godsflaw]

Ready for review

Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 1215844)
[PASS] testCastCost() (gas: 1209323)
[PASS] testFailTooEarly() (gas: 12572)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 1205734)
[PASS] testPayments() (gas: 1239758)
[PASS] testSpellIsCast_GENERAL() (gas: 11082810)
[PASS] test_auth() (gas: 9223336852493024829)
[PASS] test_auth_in_sources() (gas: 9223336852484404070)
[PASS] test_bytecode_matches() (gas: 1666433)
[PASS] test_nextCastTime() (gas: 338900)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 14 passed; 0 failed; finished in 12.84s

[iamchrissmith]

Full checklist pre-deploy review:

• [x] Standard Code review
• [x] Office Hours
  • [x] off
  • [x] matches exec doc
• [x] Exec Hash
  • community commit is the latest change or merge commit
  • community repo url matches
  • script matches
• [x] 30 Days Expiry
• [x] Pragma OK
  • No Collateral Onboarding
    • [x] no pragma experimental ABIEncoderV2;
• [x] links to polls for each relevant section/action
• [x] dss-interfaces
  • [x] submodule matches github master commit
  • [x] used in the current spell
• [x] Rates OK
  • IPFS
  • bc -l <<< 'scale=27; e( l(1.0X)/(60 * 60 * 24 * 365) )' (replace X with %, e.g. 1 = 1%)
• [x] addresses_mainnet.sol Matches
• [x] Spell Actions Look Good
• [x] Tests Look Good
• [x] Delegate Payments
  • [x] Addresses Match
  • [x] Amounts Match
• [x] CU payments
  • [x] Addresses Match
  • [x] Amounts Match

[godsflaw]

Ready for final review with deployed spell address and archive:

Running 14 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12139)
[PASS] test_auth_in_sources() (gas: 281473904945375)
[PASS] test_use_eta() (gas: 336955)
[PASS] testOnTime() (gas: 1320693)
[PASS] testPayments() (gas: 1348717)
[PASS] test_nextCastTime() (gas: 337900)
[PASS] testFailTooEarly() (gas: 8572)
[PASS] test_bytecode_matches() (gas: 1693354)
[PASS] testAAVEDirectBarChange() (gas: 1324303)
[PASS] test_auth() (gas: 281473913566549)
[PASS] testSpellIsCast_GENERAL() (gas: 10819551)
[PASS] testFailWrongDay() (gas: 8594)
[PASS] testCastCost() (gas: 1322282)
[PASS] testFailTooLate() (gas: 8549)

[brianmcmichael]

CI is failing likely due to timeout on auth tests.

We can remove them now and add them back in when CI is upgraded to foundry.