search

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
106 stars 45 forks source link

Onboard WSTETH-B #244

Closed Lollike closed 2 years ago

Lollike commented 2 years ago

Description

All tests are passing except for the chainlog address for the new MCD_VEST_DAI address, because the current mainnet spell has not been voted in yet. It should pass once the current executive is ratified.

Running 17 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testCastCost() (gas: 1865781) [PASS] testCollateralIntegrations() (gas: 2636025) [PASS] testFailTooEarly() (gas: 403935) [PASS] testFailTooLate() (gas: 403846) [PASS] testFailWrongDay() (gas: 403825) [PASS] testFail_notScheduled() (gas: 14733) [PASS] testNewChainlogValues() (gas: 1885258) [PASS] testNewIlkRegistryValues() (gas: 1894674) [PASS] testOnTime() (gas: 1862068) [PASS] testSpellIsCast_GENERAL() (gas: 23887400) [PASS] test_auth() (gas: 9223336852493252777) [PASS] test_auth_in_sources() (gas: 9223336852484460982) [PASS] test_bytecode_matches() (gas: 1779267) [FAIL] test_chainlog_values() (gas: 6788367) Logs: Error: TestError/chainlog-addr-mismatch-MCD_VEST_DAI Error: a == b not satisfied [address] Expected: 0xa4c22f0e25c6630b2017979acf1f865e94695c4b Actual: 0x2cc583c0aacdac9e23cb601fda8f1a0c56cdcb71

[PASS] test_chainlog_version_bump() (gas: 3623793) [PASS] test_nextCastTime() (gas: 428535) [PASS] test_use_eta() (gas: 339790) Test result: FAILED 16 passed; 1 failed; finished in 813.66s

Failed tests: [FAIL] test_chainlog_values() (gas: 6788367)

Encountered a total of 1 failing tests, 16 tests succeeded

brianmcmichael commented 2 years ago

If you set the previous_spell value in the ./src/test/config.sol file to the spell you're waiting on the tests will simulate the cast and proceed.

Lollike commented 2 years ago

Thanks @brianmcmichael - added the suggested changes. All tests are passing now:

Running 17 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 1782452)
[PASS] testCollateralIntegrations() (gas: 2550213)
[PASS] testFailTooEarly() (gas: 320175)
[PASS] testFailTooLate() (gas: 320207)
[PASS] testFailWrongDay() (gas: 320093)
[PASS] testFail_notScheduled() (gas: 14733)
[PASS] testNewChainlogValues() (gas: 1796646)
[PASS] testNewIlkRegistryValues() (gas: 1806062)
[PASS] testOnTime() (gas: 1773456)
[PASS] testSpellIsCast_GENERAL() (gas: 23798788)
[PASS] test_auth() (gas: 9223336852493311205)
[PASS] test_auth_in_sources() (gas: 9223336852484462977)
[PASS] test_bytecode_matches() (gas: 1779267)
[PASS] test_chainlog_values() (gas: 6703658)
[PASS] test_chainlog_version_bump() (gas: 3541045)
[PASS] test_nextCastTime() (gas: 339975)
[PASS] test_use_eta() (gas: 251230)
Test result: ok. 17 passed; 0 failed; finished in 662.24s
Lollike commented 2 years ago

Accepted your suggestions @talbaneth - thank you :)